Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finalize_distribution_options entry point requires panda3d import #1624

Closed
rdb opened this issue Mar 9, 2024 · 0 comments
Closed

finalize_distribution_options entry point requires panda3d import #1624

rdb opened this issue Mar 9, 2024 · 0 comments
Assignees
Milestone

Comments

@rdb
Copy link
Member

rdb commented Mar 9, 2024

Description

Panda3D registers a finalize_distribution_options as of 1.10.13 to fix #1394, which also gets called when using commands other than build_apps due to limitations in setuptools.

However, this causes an import of FreezeTool, which imports Panda3D modules. If there is an issue with the Panda3D installation, this causes unrelated uses of setuptools to fail.

Steps to Reproduce

  1. Introduce an issue with the Panda3D C++ modules, eg. by deleting panda3d/core.so
  2. Try to install Pillow using pip
  3. Observe the panda3d.core install error

Proposed Fix

Put our finalize_distribution_options hook in a separate module, so that it doesn't trigger an import of other Panda3D modules

Environment

  • Operating system: macOS 14.4
  • System architecture: arm64
  • Panda3D version: 1.10.14+
  • Installation method: built from source
  • Python version (if using Python): 3.12
@rdb rdb added the regression label Mar 9, 2024
@rdb rdb added this to the 1.10.15 milestone Mar 9, 2024
@rdb rdb self-assigned this Mar 27, 2024
@rdb rdb closed this as completed in 1f41edd Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant