Skip to content
This repository has been archived by the owner on Jun 12, 2023. It is now read-only.

Start Using GitHub Actions #20

Open
WillAyd opened this issue Nov 29, 2019 · 7 comments
Open

Start Using GitHub Actions #20

WillAyd opened this issue Nov 29, 2019 · 7 comments

Comments

@WillAyd
Copy link
Member

WillAyd commented Nov 29, 2019

Up for discussion, but I released a third party package that leverages pandas and when it came time to build wheels, I found that GitHub Actions actually offers a lot we can use. Here's is a sample configuration that gets triggered on release:

https://github.com/innobi/pantab/blob/master/.github/workflows/pythonpublish.yml

This builds "artifacts" in CI that can then be downloaded containing the appropriate wheels:

image

A few limitations AFAIK:

  • There is no win32 platform to build wheels on
  • I think ubuntu 16.02 is the oldest available linux platform, which I don't think can build manylinux wheels

So may not have everything we need at the moment, but figure worth starting the discussion as I think this could great simplify our release process

@jreback
Copy link

jreback commented Nov 29, 2019

w/o the ability to build manylinux wheels this is a non-starter

@WillAyd
Copy link
Member Author

WillAyd commented Nov 29, 2019

Yea I think would have to run the manylinux containers within an action for that

@TomAugspurger
Copy link
Collaborator

https://github.com/explosion/wheelwright may be worth looking into (azure pipelines, rather than GH actions).

@jreback
Copy link

jreback commented Jan 30, 2020

https://github.com/explosion/wheelwright may be worth looking into (azure pipelines, rather than GH actions).

this looks nice and is based on multibuild

@jreback
Copy link

jreback commented Jan 30, 2020

we could build the wheels and install / test on them (maybe. not all flavors as that’s expensive but some)

@WillAyd
Copy link
Member Author

WillAyd commented Feb 5, 2020

So in my other project I started building many linux wheels using the Docker container that pypi publishes. Here is what that GH Action looks like:

https://github.com/innobi/pantab/blob/master/.github/workflows/pythonpublish.yml

Along with the script run within docker to actually build and audit the wheels:

https://github.com/innobi/pantab/blob/master/manylinux_build.sh

@WillAyd
Copy link
Member Author

WillAyd commented Feb 28, 2020

@momisbestfriend pointed out https://github.com/joerick/cibuildwheel and has vouched for it

Haven't gone too deep but may be the easiest option and I don't think requires a separate repo

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants