BUG: Timestamp.unit now reflects changes in components after Timestamp.replace #58121
+47
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Non-Nano
diogomsmiranda
force-pushed
the
reflect-changes-in-components
branch
4 times, most recently
from
c3a4ebf
to
5a62136
Compare
jbrockmendel
reviewed
Apr 8, 2024
|
Hey, I've made the requested changes. |
|
@jbrockmendel @mroeschke Hey!! Sorry for the ping but it's been a while since I last heard from you, is this change still of interest? Let me know If you need anything from me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timestamp.unitshould reflect changes in components afterTimestamp.replace#57749doc/source/whatsnew/v3.0.0.rstThe logic behind this is having the
Timestamp.unitset as the most precise unit changed onTimestamp.replaceif one is more precise than the previous set.