BUG: DatetimeIndex.is_year_start breaks on custom business days frequencies bigger then 1C
#58665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
May 10, 2024
doc/source/whatsnew/v3.0.0.rst
Outdated
| @@ -419,6 +419,7 @@ Interval | |||
| Indexing | |||
| ^^^^^^^^ | |||
| - Bug in :meth:`DataFrame.__getitem__` returning modified columns when called with ``slice`` in Python 3.12 (:issue:`57500`) | |||
| - Bug in :meth:`DatetimeIndex.is_year_start` and :meth:`DatetimeIndex.is_quarter_start` does not raise on Custom business days frequencies bigger then "1C" (:issue:`58664`) | |||
There was a problem hiding this comment.
Could you put this under Datetimelike?
mroeschke
reviewed
May 10, 2024
pandas/_libs/tslibs/fields.pyx
Outdated
|
|
||
| # YearBegin(), BYearBegin() use month = starting month of year. | ||
| # QuarterBegin(), BQuarterBegin() use startingMonth = starting | ||
| # month of year. Other offsets use month, startingMonth as ending | ||
| # month of year. | ||
|
|
||
| if (freqstr[0:2] in ["MS", "QS", "YS"]) or ( | ||
| freqstr[1:3] in ["MS", "QS", "YS"]): | ||
| if freq_name.lstrip("B")[0:2] in ["MS", "QS", "YS"]: |
There was a problem hiding this comment.
Suggested change
| if freq_name.lstrip("B")[0:2] in ["MS", "QS", "YS"]: | |
| if freq_name.lstrip("B")[0:2] in ["MS", "QS", "YS"]: |
|
this needs rebasing, as it contains commits from the other PR (and could you move the whatsnew from that one to (other than that, it looks like this identifies + fixes the issue, nice) |
thanks, rebased and moved the whatsnew note from |
mroeschke
approved these changes
May 11, 2024
|
Thanks @natmokval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1C#58664