Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: Deprecate method argument of reindex_like #58667

Closed
3 tasks done
WillAyd opened this issue May 10, 2024 · 4 comments · Fixed by #58724
Closed
3 tasks done

DEPR: Deprecate method argument of reindex_like #58667

WillAyd opened this issue May 10, 2024 · 4 comments · Fixed by #58724
Assignees
Labels
Deprecate Functionality to remove in pandas Enhancement good first issue

Comments

@WillAyd
Copy link
Member

WillAyd commented May 10, 2024

Feature Type

  • Adding new functionality to pandas

  • Changing existing functionality in pandas

  • Removing existing functionality in pandas

Problem Description

There is a bug report of this in #34547 The current behavior of the method seems to work closer to DataFrame.update (whether intentional or not). Rather than try and fix I think it would be better to remove the parameter and have users call .fillna() or .update() to get the intended result

Feature Description

Deprecate

Alternative Solutions

N/A

Additional Context

No response

@WillAyd WillAyd added Enhancement Needs Triage Issue that has not been reviewed by a pandas team member Deprecate Functionality to remove in pandas good first issue and removed Needs Triage Issue that has not been reviewed by a pandas team member labels May 10, 2024
@jasonmokk
Copy link
Contributor

take

@jasonmokk jasonmokk removed their assignment May 11, 2024
@PedroVerardo
Copy link

take

@PedroVerardo
Copy link

Hi, I'm wondering what the procedure is to deprecate a keyword argument of a method when there is no new name for it, just removing it. Should I change the code to remove the argument and add a deprecation warning, or should I simply add the deprecation warning?

@tomytp
Copy link
Contributor

tomytp commented May 15, 2024

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas Enhancement good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants