Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requestResource return type #488

Closed
coffe0wl opened this issue Apr 15, 2022 · 3 comments
Closed

requestResource return type #488

coffe0wl opened this issue Apr 15, 2022 · 3 comments
Labels
invalid

Comments

@coffe0wl
Copy link

The documentation(Image1) states that the requestResource method returns the promise but in reality it doesn't(Image2)

Image1

image

Image2

image
@panva panva removed the triage label Apr 16, 2022
@panva
Copy link
Owner

panva commented Apr 16, 2022

It sure does return a Promise, it's an async function.

@panva panva closed this as completed Apr 16, 2022
@panva panva added the invalid label Apr 16, 2022
@coffe0wl
Copy link
Author

Yes, but not in the index.d.ts file
image

@panva
Copy link
Owner

panva commented Apr 16, 2022

The documentation states that the requestResource method returns the promise but in reality it doesn't.

That is what I checked.

Would you like to submit a PR to fix the types?

@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2022
panva pushed a commit that referenced this issue Nov 28, 2022
@roemba
fix(typescript): requestResource returns a Promise (#546)
8bc9519 
Closes #488
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
invalid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@panva @coffe0wl