Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack Warning Error #1001

Closed
adeelibr opened this issue Jan 4, 2017 · 6 comments
Closed

Webpack Warning Error #1001

adeelibr opened this issue Jan 4, 2017 · 6 comments
Projects

Comments

@adeelibr
Copy link

adeelibr commented Jan 4, 2017

This is the error I get when I include jsPdf

WARNING in ./~/jspdf/dist/jspdf.debug.js Critical dependencies: 12380:444-451 This seems to be a pre-built javascript file. Though this is possible, it's not recommended. Try to require the original source to get better results. @ ./~/jspdf/dist/jspdf.debug.js 12380:444-451

It works okay, but I still get this warning message.

@simonbengtsson
Copy link
Contributor

simonbengtsson commented Jan 4, 2017

The warning stems from that some of the third party libraries included in the jspdf.debug.js bundle are minified. Hopefully @MrRio accepts a pull request for making jspdf more modular which would enable a better webpack workflow and drastically reduce the library size. See #839 for a discussion related to this.

@adeelibr
Copy link
Author

adeelibr commented Jan 5, 2017

Okay thankyou @simonbengtsson , Hoping that @MrRio accepts than pull request soon.

@bounis
Copy link

bounis commented May 2, 2017

this bug is caused by the html2canvas lib.
if you change the version of this lib from 0.5.0-beta to 0.5.0-alpha you will get this working well

@rflmyk
Copy link

rflmyk commented Jun 9, 2017

+1

1 similar comment
@nicholaai
Copy link

+1

@Uzlopak Uzlopak closed this as completed May 27, 2018
@Uzlopak Uzlopak reopened this May 27, 2018
@Uzlopak Uzlopak added this to Done in jsPDF 1.4.1 May 27, 2018
@Uzlopak Uzlopak moved this from Done to To do in jsPDF 1.4.1 May 27, 2018
@Uzlopak Uzlopak moved this from To do to In progress in jsPDF 1.4.1 Jun 2, 2018
@Uzlopak Uzlopak closed this as completed Jun 2, 2018
@Uzlopak Uzlopak moved this from In progress to Done in jsPDF 1.4.1 Jun 2, 2018
@git-gru
Copy link

git-gru commented Jul 4, 2018

Go to webpack.config.js and add this line to module:

noParse: /node_modules/jspdf/dist/jspdf.min.js/,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
jsPDF 1.4.1
  
Done
Development

No branches or pull requests

7 participants