Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for canvg >= 3 #2732

Closed
gustavi opened this issue Apr 28, 2020 · 6 comments
Closed

Add support for canvg >= 3 #2732

gustavi opened this issue Apr 28, 2020 · 6 comments
Labels
Improvement no-issue-activity

Comments

@gustavi
Copy link

gustavi commented Apr 28, 2020

canvg 3.0 was release in December 2019 an introduce some breaking changes .

Currently jsPDF is not compatible but I think they are minor changes to make it works.
@HackbrettXXX
Copy link
Collaborator

See #2729

@gustavi
Copy link
Author

gustavi commented Apr 28, 2020 •
edited

This PR update canvg to 2.0, not 3.0.

Currently canvg 2.0 works without any change on jsPDF but the 3.0+ is not compatible and require changes on jsPDF.

@HackbrettXXX
Copy link
Collaborator

Ah sorry. In this case, it's definitely a good idea to update to 3.0.

@HackbrettXXX HackbrettXXX reopened this Apr 28, 2020
@github-actions
Copy link

This issue is stale because it has been open 90 days with no activity. It will be closed soon. Please comment/reopen if this issue is still relevant.

@HackbrettXXX
Copy link
Collaborator

#2804 updated to canvg 3.0

@gustavi
Copy link
Author

gustavi commented Jul 28, 2020

Thanks a lot !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement no-issue-activity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gustavi @HackbrettXXX