Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The variable type in documentation should be number, not string #2912

Closed
izdwuut opened this issue Sep 13, 2020 · 2 comments
Closed

The variable type in documentation should be number, not string #2912

izdwuut opened this issue Sep 13, 2020 · 2 comments

Comments

@izdwuut
Copy link
Contributor

izdwuut commented Sep 13, 2020 •
edited

Hi

This is the line that contains the wrong type. As the topic says, it should be number, not string.
@HackbrettXXX
Copy link
Collaborator

HackbrettXXX commented Sep 14, 2020 •
edited

Yes, seems like many of the text arguments have the wrong type. Could you prepare a pull request fixing the types in the JSDoc comment of the text method?

@izdwuut izdwuut mentioned this issue Sep 15, 2020
Merged
@izdwuut
Copy link
Contributor Author

izdwuut commented Sep 15, 2020 •
edited

Sure. Here's my pull request.

@izdwuut izdwuut closed this as completed Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HackbrettXXX @izdwuut