Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for jsPDF.output() #3081

Closed
shaielc opened this issue Jan 30, 2021 · 2 comments
Closed

Documentation for jsPDF.output() #3081

shaielc opened this issue Jan 30, 2021 · 2 comments

Comments

@shaielc
Copy link

shaielc commented Jan 30, 2021

This is the current documentation for jsPDF.output():
image

  1. The function doesn't return a jsPDF it returns a string
  2. The function clearly doesn't just return a string it opens a new window ( or at least I am guessing it does since there's the option for 'dataurlnewwindow'.

is there documentation for each of the types since clearly the functionality is not the same.

@HackbrettXXX
Copy link
Collaborator

I agree the documentation is not optimal and not perfectly correct. Pull requests to improve this are very welcome :)

@HackbrettXXX
Copy link
Collaborator

Fixed in #3099.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants