Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddImage does not support files of type 'UNKNOWN' #3692

Open
HADB opened this issue Jan 16, 2024 · 5 comments · May be fixed by #3693
Open

AddImage does not support files of type 'UNKNOWN' #3692

HADB opened this issue Jan 16, 2024 · 5 comments · May be fixed by #3693

Comments

@HADB
Copy link

HADB commented Jan 16, 2024

I found my jpeg header starts with FF D8 FF E2, which is not supported.

Here is the demo jpeg file:

hello-world

QQ截图20240116235923

@HADB
Copy link
Author

HADB commented Jan 16, 2024

Here's what I found: GCK'S FILE SIGNATURES TABLE

NOTES on JPEG file headers: The proper JPEG header is the two-byte sequence, 0xFF-D8, aka Start of Image (SOI) marker.
JPEG files end with the two-byte sequence, 0xFF-D9, aka End of Image (EOI) marker.

Between the SOI and EOI, JPEG files are composed of segments. Segments start with a two-byte Segment Tag followed by a
two-byte Segment Length field and then a zero-terminated string identifier (i.e., a character string followed by a 0x00), as
shown below with the JFIF, Exif, and SPIFF segments.

Segment Tags of the form 0x-FF-Ex (where x = 0..F) are referred to as APP0-APP15, and contain application-specific information. The most commonly seen APP segments at the beginning of a JPEG file are APP0 and APP1 although others are also seen. Some additional tags are shown below:

@HADB HADB linked a pull request Jan 16, 2024 that will close this issue
@HADB
Copy link
Author

HADB commented Jan 16, 2024

According to GCK'S FILE SIGNATURES TABLE, I created a PR(#3693) which supports CIFF & SPIFF files and will close this issue.

Copy link

This issue is stale because it has been open 90 days with no activity. It will be closed soon. Please comment/reopen if this issue is still relevant.

@HADB
Copy link
Author

HADB commented Apr 16, 2024

#3693 still not merged.

@HADB
Copy link
Author

HADB commented Apr 16, 2024

This issue is stale because it has been open 90 days with no activity. It will be closed soon. Please comment/reopen if this issue is still relevant.

Not this issue is stale but this whole project is stale!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant