Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semantic-ui-css stylesheet fails to parse #690

Open
timneutkens opened this issue Mar 3, 2024 · 3 comments
Open

semantic-ui-css stylesheet fails to parse #690

timneutkens opened this issue Mar 3, 2024 · 3 comments

Comments

@timneutkens
Copy link

While checking all Next.js examples against Next.js with Turbopack (which uses lightningcss by default) we got a parsing issue reported related to semantic-ui-css package.

The CSS in node_modules/semantic-ui-css/semantic.min.css results in ERROR: Unexpected token Delim('.').

After digging to find a minimal reproduction I've found that in particular this line causes the error, when it's removed the file parses correctly:

[data-tooltip][data-inverted]:after .header {   background-color: none;   color: #fff; }

Here's a playground link that reproduces: https://lightningcss.dev/playground/index.html#%7B%22minify%22%3Atrue%2C%22customMedia%22%3Atrue%2C%22cssModules%22%3Afalse%2C%22analyzeDependencies%22%3Afalse%2C%22targets%22%3A%7B%22chrome%22%3A6225920%7D%2C%22include%22%3A0%2C%22exclude%22%3A0%2C%22source%22%3A%22%5Bdata-tooltip%5D%5Bdata-inverted%5D%3Aafter%20.header%20%7B%5Cn%20%20background-color%3A%20none%3B%5Cn%20%20color%3A%20%23fff%3B%5Cn%7D%22%2C%22visitorEnabled%22%3Afalse%2C%22visitor%22%3A%22%22%2C%22unusedSymbols%22%3A%5B%5D%2C%22version%22%3A%22local%22%7D

@mischnic
Copy link
Member

mischnic commented Mar 3, 2024

That is an invalid selector: #648

@timneutkens
Copy link
Author

Hmm I guess we could disable the strict parsing for node_modules by default but I'm not opposed to having strict parsing by default in order to prevent unexpected behavior.

@timneutkens
Copy link
Author

Seems the library is unmaintained so I'm going to remove the example in the Next.js repository instead. Thanks for the link @mischnic, super helpful!

Will keep this issue open as the error could be more helpful for this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants