From 0759d1b4a66f650c72be23913c30a8aaa87ebd45 Mon Sep 17 00:00:00 2001 From: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com> Date: Sun, 30 Oct 2022 14:45:20 +0100 Subject: [PATCH] Make polyfill version validation a warning (#8579) --- .../node-resolver-core/src/NodeResolver.js | 30 +++++++++++-------- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/packages/utils/node-resolver-core/src/NodeResolver.js b/packages/utils/node-resolver-core/src/NodeResolver.js index 51663daaddb..e2dd444429e 100644 --- a/packages/utils/node-resolver-core/src/NodeResolver.js +++ b/packages/utils/node-resolver-core/src/NodeResolver.js @@ -27,9 +27,10 @@ import { isGlobMatch, } from '@parcel/utils'; import ThrowableDiagnostic, { + encodeJSONKeyComponent, + errorToDiagnostic, generateJSONCodeHighlights, md, - encodeJSONKeyComponent, } from '@parcel/diagnostic'; import builtins, {empty} from './builtins'; import nullthrows from 'nullthrows'; @@ -377,18 +378,21 @@ export default class NodeResolver { } } else if (builtin.range != null) { // Assert correct version - - // TODO packageManager can be null for backwards compatibility, but that could cause invalid - // resolutions in monorepos - await packageManager?.resolve( - packageName, - this.projectRoot + '/index', - { - saveDev: true, - shouldAutoInstall: this.shouldAutoInstall, - range: builtin.range, - }, - ); + try { + // TODO packageManager can be null for backwards compatibility, but that could cause invalid + // resolutions in monorepos + await packageManager?.resolve( + packageName, + this.projectRoot + '/index', + { + saveDev: true, + shouldAutoInstall: this.shouldAutoInstall, + range: builtin.range, + }, + ); + } catch (e) { + this.logger?.warn(errorToDiagnostic(e)); + } } }