From de2085afc9d85ca26783b830a2a91a04730a5a48 Mon Sep 17 00:00:00 2001
From: Gora Kong <gora.kong1@gmail.com>
Date: Wed, 1 Jun 2022 18:41:07 -0700
Subject: [PATCH] add test and assert on number of bundles instead

---
 packages/core/integration-tests/test/cache.js | 58 +------------------
 .../test/integration/large-bundlegroup/a.js   |  1 +
 .../test/integration/large-bundlegroup/b.js   |  1 +
 .../test/integration/large-bundlegroup/c.js   |  1 +
 .../test/integration/large-bundlegroup/d.js   |  1 +
 .../integration/large-bundlegroup/index.js    |  4 ++
 .../large-bundlegroup/package.json            |  1 +
 .../integration/large-bundlegroup/yarn.lock   |  0
 8 files changed, 11 insertions(+), 56 deletions(-)
 create mode 100644 packages/core/integration-tests/test/integration/large-bundlegroup/a.js
 create mode 100644 packages/core/integration-tests/test/integration/large-bundlegroup/b.js
 create mode 100644 packages/core/integration-tests/test/integration/large-bundlegroup/c.js
 create mode 100644 packages/core/integration-tests/test/integration/large-bundlegroup/d.js
 create mode 100644 packages/core/integration-tests/test/integration/large-bundlegroup/index.js
 create mode 100644 packages/core/integration-tests/test/integration/large-bundlegroup/package.json
 create mode 100644 packages/core/integration-tests/test/integration/large-bundlegroup/yarn.lock

diff --git a/packages/core/integration-tests/test/cache.js b/packages/core/integration-tests/test/cache.js
index a5eee6be34d..45adaaca801 100644
--- a/packages/core/integration-tests/test/cache.js
+++ b/packages/core/integration-tests/test/cache.js
@@ -4451,29 +4451,7 @@ describe('cache', function () {
               );
             },
             async update(b) {
-              assertBundles(b.bundleGraph, [
-                {
-                  name: 'index.js',
-                  type: 'js',
-                  assets: [
-                    'bundle-manifest.js',
-                    'bundle-url.js',
-                    'cacheLoader.js',
-                    'index.js',
-                    'js-loader.js',
-                  ],
-                },
-                {name: 'a.25c87b34.js', type: 'js', assets: ['a.js']},
-                {name: 'a.6aa86d57.js', type: 'js', assets: ['lodash.js']},
-                {name: 'b.9d35301a.js', type: 'js', assets: ['b.js']},
-                {
-                  name: 'b.0c79a272.js',
-                  type: 'js',
-                  assets: ['index.js', 'index.js', 'react.development.js'],
-                },
-                {name: 'c.09dec791.js', type: 'js', assets: ['c.js']},
-                {name: 'd.004d4333.js', type: 'js', assets: ['d.js']},
-              ]);
+              assert(b.bundleGraph.getBundles().length, 7);
               let pkgFile = path.join(inputDir, 'package.json');
               let pkg = JSON.parse(await overlayFS.readFile(pkgFile));
               await overlayFS.writeFile(
@@ -4492,39 +4470,7 @@ describe('cache', function () {
           },
           'large-bundlegroup',
         );
-        assertBundles(b.bundleGraph, [
-          {
-            name: 'index.js',
-            type: 'js',
-            assets: [
-              'bundle-manifest.js',
-              'bundle-url.js',
-              'cacheLoader.js',
-              'index.js',
-              'js-loader.js',
-            ],
-          },
-          {
-            name: 'a.63720eaa.js',
-            type: 'js',
-            assets: ['a.js', 'lodash.js'],
-          },
-          {
-            name: 'b.8cde6b4e.js',
-            type: 'js',
-            assets: ['b.js', 'index.js', 'index.js', 'react.development.js'],
-          },
-          {
-            name: 'c.3cd1de9a.js',
-            type: 'js',
-            assets: ['c.js', 'lodash.js'],
-          },
-          {
-            name: 'd.1cd4208a.js',
-            type: 'js',
-            assets: ['d.js', 'index.js', 'index.js', 'react.development.js'],
-          },
-        ]);
+        assert(b.bundleGraph.getBundles().length, 5);
       });
 
       it('should support updating bundler config', async function () {
diff --git a/packages/core/integration-tests/test/integration/large-bundlegroup/a.js b/packages/core/integration-tests/test/integration/large-bundlegroup/a.js
new file mode 100644
index 00000000000..8d080affc6e
--- /dev/null
+++ b/packages/core/integration-tests/test/integration/large-bundlegroup/a.js
@@ -0,0 +1 @@
+module.exports = require('lodash').add(1, 1);
diff --git a/packages/core/integration-tests/test/integration/large-bundlegroup/b.js b/packages/core/integration-tests/test/integration/large-bundlegroup/b.js
new file mode 100644
index 00000000000..f897854c19e
--- /dev/null
+++ b/packages/core/integration-tests/test/integration/large-bundlegroup/b.js
@@ -0,0 +1 @@
+module.exports = require("react");
diff --git a/packages/core/integration-tests/test/integration/large-bundlegroup/c.js b/packages/core/integration-tests/test/integration/large-bundlegroup/c.js
new file mode 100644
index 00000000000..22fd70818f4
--- /dev/null
+++ b/packages/core/integration-tests/test/integration/large-bundlegroup/c.js
@@ -0,0 +1 @@
+module.exports = require('lodash').add(2, 2);
diff --git a/packages/core/integration-tests/test/integration/large-bundlegroup/d.js b/packages/core/integration-tests/test/integration/large-bundlegroup/d.js
new file mode 100644
index 00000000000..f897854c19e
--- /dev/null
+++ b/packages/core/integration-tests/test/integration/large-bundlegroup/d.js
@@ -0,0 +1 @@
+module.exports = require("react");
diff --git a/packages/core/integration-tests/test/integration/large-bundlegroup/index.js b/packages/core/integration-tests/test/integration/large-bundlegroup/index.js
new file mode 100644
index 00000000000..edb2fd021f2
--- /dev/null
+++ b/packages/core/integration-tests/test/integration/large-bundlegroup/index.js
@@ -0,0 +1,4 @@
+import('./a.js');
+import('./b.js');
+import('./c.js');
+import('./d.js');
diff --git a/packages/core/integration-tests/test/integration/large-bundlegroup/package.json b/packages/core/integration-tests/test/integration/large-bundlegroup/package.json
new file mode 100644
index 00000000000..0967ef424bc
--- /dev/null
+++ b/packages/core/integration-tests/test/integration/large-bundlegroup/package.json
@@ -0,0 +1 @@
+{}
diff --git a/packages/core/integration-tests/test/integration/large-bundlegroup/yarn.lock b/packages/core/integration-tests/test/integration/large-bundlegroup/yarn.lock
new file mode 100644
index 00000000000..e69de29bb2d