From 625935be0de3001882274b2e58d5e2b30d03ff13 Mon Sep 17 00:00:00 2001
From: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>
Date: Thu, 3 Nov 2022 17:58:24 +0100
Subject: [PATCH] Make uniqueKey undefined by default (#8601)

---
 packages/core/core/src/assetUtils.js               |  2 +-
 .../integration/resolve-empty-specifier/index.js   |  1 +
 packages/core/integration-tests/test/resolver.js   | 14 ++++++++++++++
 3 files changed, 16 insertions(+), 1 deletion(-)
 create mode 100644 packages/core/integration-tests/test/integration/resolve-empty-specifier/index.js

diff --git a/packages/core/core/src/assetUtils.js b/packages/core/core/src/assetUtils.js
index 0cf7cc44724..a4961173688 100644
--- a/packages/core/core/src/assetUtils.js
+++ b/packages/core/core/src/assetUtils.js
@@ -126,7 +126,7 @@ export function createAsset(
         ]),
       ),
     sideEffects: options.sideEffects ?? true,
-    uniqueKey: options.uniqueKey ?? '',
+    uniqueKey: options.uniqueKey,
     plugin: options.plugin,
     configPath: options.configPath,
     configKeyPath: options.configKeyPath,
diff --git a/packages/core/integration-tests/test/integration/resolve-empty-specifier/index.js b/packages/core/integration-tests/test/integration/resolve-empty-specifier/index.js
new file mode 100644
index 00000000000..e7dedbd0df9
--- /dev/null
+++ b/packages/core/integration-tests/test/integration/resolve-empty-specifier/index.js
@@ -0,0 +1 @@
+import "";
diff --git a/packages/core/integration-tests/test/resolver.js b/packages/core/integration-tests/test/resolver.js
index d99b93c9c41..8d0dd2a2798 100644
--- a/packages/core/integration-tests/test/resolver.js
+++ b/packages/core/integration-tests/test/resolver.js
@@ -1,3 +1,4 @@
+// @flow strict-local
 import assert from 'assert';
 import path from 'path';
 import {bundle, run, ncp, overlayFS, outputFS} from '@parcel/test-utils';
@@ -398,4 +399,17 @@ describe('resolver', function () {
       inputFS: overlayFS,
     });
   });
+
+  it('should support empty dependency specifiers', async function () {
+    // $FlowFixMe[prop-missing];
+    await assert.rejects(
+      () =>
+        bundle(
+          path.join(__dirname, '/integration/resolve-empty-specifier/index.js'),
+        ),
+      {
+        message: `Failed to resolve '' from './integration/resolve-empty-specifier/index.js'`,
+      },
+    );
+  });
 });