From 7ca56f97cfbc03fa05cef43dfadd399369b9e7de Mon Sep 17 00:00:00 2001 From: chocolateboy Date: Thu, 6 Sep 2018 18:26:17 +0000 Subject: [PATCH] Don't resolve slash and tilde paths twice (#1993) Fix "Cannot resolve dependency" errors for valid slash and tilde paths. Before: /src/js/index.js -> /home/user/my-project/src/js/index.js -> /home/user/my-project/home/user/my-project/src/js/index.js Error: Cannot resolve dependency /home/user/my-project/src/js/index.js After: /src/js/index.js -> /home/user/my-project/src/js/index.js The code already has a way for asset-handlers to signal to the bundler that a dependency has been resolved to an absolute path, but it isn't being used. fixes #1555 fixes #1986 --- packages/core/parcel-bundler/src/Asset.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/parcel-bundler/src/Asset.js b/packages/core/parcel-bundler/src/Asset.js index 7406c129c16..e4842a52b99 100644 --- a/packages/core/parcel-bundler/src/Asset.js +++ b/packages/core/parcel-bundler/src/Asset.js @@ -107,7 +107,7 @@ class Asset { depName = './' + path.relative(path.dirname(this.name), resolved); } - this.addDependency(depName, Object.assign({dynamic: true}, opts)); + this.addDependency(depName, Object.assign({dynamic: true, resolved}, opts)); parsed.pathname = this.options.parser .getAsset(resolved, this.options)