From af76afc12109040abfbe0eaf13b2465ba99b1678 Mon Sep 17 00:00:00 2001 From: Shinobu Hayashi Date: Sun, 26 Dec 2021 01:28:18 +0900 Subject: [PATCH] Feature: support href attribute in in collecting dependencies in HTMLTransformer (#7482) --- packages/core/integration-tests/test/html.js | 17 +++++++++++++++++ .../html-image-href-attr/100x100.png | Bin 0 -> 255 bytes .../html-image-href-attr/index.html | 13 +++++++++++++ packages/transformers/html/src/dependencies.js | 2 +- 4 files changed, 31 insertions(+), 1 deletion(-) create mode 100644 packages/core/integration-tests/test/integration/html-image-href-attr/100x100.png create mode 100644 packages/core/integration-tests/test/integration/html-image-href-attr/index.html diff --git a/packages/core/integration-tests/test/html.js b/packages/core/integration-tests/test/html.js index 61da006ca62..ec252cc8423 100644 --- a/packages/core/integration-tests/test/html.js +++ b/packages/core/integration-tests/test/html.js @@ -965,6 +965,23 @@ describe('html', function () { ]); }); + it("should support href attribute in in HTMLTransformer's collectDependencies", async function () { + let b = await bundle( + path.join(__dirname, '/integration/html-image-href-attr/index.html'), + ); + + assertBundles(b, [ + { + name: 'index.html', + assets: ['index.html'], + }, + { + type: 'png', + assets: ['100x100.png'], + }, + ]); + }); + // Based on https://developer.mozilla.org/en-US/docs/Web/SVG/Element/script it('should bundle scripts inside svg', async function () { let b = await bundle( diff --git a/packages/core/integration-tests/test/integration/html-image-href-attr/100x100.png b/packages/core/integration-tests/test/integration/html-image-href-attr/100x100.png new file mode 100644 index 0000000000000000000000000000000000000000..8a1daa0121d524256c1d1b45ff5e7ed771784c52 GIT binary patch literal 255 zcmeAS@N?(olHy`uVBq!ia0vp^DImVS)*E46%Oq(`s&YU^>_U&7| zc=6GrN4Ia^zG~H~jT<-Ko_$0QsEo6~BeIx*f$sR&2=kJHM z&5N9@w|=XzipNCbb|s-xrJeH)f2E%im~OIrio1Qy&Sj1+>x<+1)+oPni}kGd6Ohy! z>6x1RttNZTv!7LG>?+Ii&zjEnadB}e3778<6P>u`Anzuis~9|8{an^LB{Ts5qZeh6 literal 0 HcmV?d00001 diff --git a/packages/core/integration-tests/test/integration/html-image-href-attr/index.html b/packages/core/integration-tests/test/integration/html-image-href-attr/index.html new file mode 100644 index 00000000000..56638e1ad6d --- /dev/null +++ b/packages/core/integration-tests/test/integration/html-image-href-attr/index.html @@ -0,0 +1,13 @@ + + + + + + + + + + + + + diff --git a/packages/transformers/html/src/dependencies.js b/packages/transformers/html/src/dependencies.js index f70d102cbee..f94180c3662 100644 --- a/packages/transformers/html/src/dependencies.js +++ b/packages/transformers/html/src/dependencies.js @@ -18,7 +18,7 @@ const ATTRS = { 'amp-img', ], // Using href with