From 35a58ccac17dad592e877261b73adef6c7b06276 Mon Sep 17 00:00:00 2001 From: Will Binns-Smith Date: Wed, 13 Mar 2019 13:19:41 -0700 Subject: [PATCH 1/8] JSTransformer: Declare necessary dependencies --- packages/transformers/js/package.json | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/packages/transformers/js/package.json b/packages/transformers/js/package.json index 50099b98220..c73bcff2ab5 100644 --- a/packages/transformers/js/package.json +++ b/packages/transformers/js/package.json @@ -15,7 +15,19 @@ "prepublish": "yarn build" }, "dependencies": { - "@parcel/plugin": "^2.0.0" + "@babel/core": "^7.0.0", + "@babel/generator": "^7.0.0", + "@babel/parser": "^7.0.0", + "@babel/plugin-transform-modules-commonjs": "^7.0.0", + "@babel/template": "^7.0.0", + "@babel/traverse": "^7.0.0", + "@babel/types": "^7.0.0", + "@parcel/logger": "^1.10.3", + "@parcel/plugin": "^2.0.0", + "@parcel/utils": "^1.10.3", + "babylon-walk": "^1.0.2", + "node-libs-browser": "^2.0.0", + "semver": "^5.4.1" }, "devDependencies": { "@parcel/eslint-config": "1.10.3" From a7de47ae32a5ee3925a718b1612c66fd2bbbd04f Mon Sep 17 00:00:00 2001 From: Will Binns-Smith Date: Wed, 13 Mar 2019 13:28:54 -0700 Subject: [PATCH 2/8] Babel Transformer: Declare necessary dependencies --- packages/transformers/babel/package.json | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/packages/transformers/babel/package.json b/packages/transformers/babel/package.json index 9b86ea94ecc..e4e98611a2d 100644 --- a/packages/transformers/babel/package.json +++ b/packages/transformers/babel/package.json @@ -15,7 +15,19 @@ "prepublish": "yarn build" }, "dependencies": { - "@parcel/plugin": "^2.0.0" + "@babel/core": "^7.0.0", + "@babel/generator": "^7.0.0", + "@babel/plugin-transform-flow-strip-types": "^7.0.0", + "@babel/plugin-transform-react-jsx": "^7.0.0", + "@babel/preset-env": "^7.0.0", + "@babel/traverse": "^7.0.0", + "@parcel/fs": "^1.10.3", + "@parcel/logger": "^1.10.3", + "@parcel/plugin": "^2.0.0", + "@parcel/utils": "^1.10.3", + "browserslist": "^4.1.0", + "micromatch": "^3.0.4", + "semver": "^5.4.1" }, "devDependencies": { "@parcel/eslint-config": "1.10.3" From 4c514cf76ee3d340fcf5e85287cabe84a3485df5 Mon Sep 17 00:00:00 2001 From: Will Binns-Smith Date: Wed, 13 Mar 2019 13:53:36 -0700 Subject: [PATCH 3/8] Add missing dependencies for watcher, default resolver, and terser transform --- packages/core/parcel-bundler/package.json | 1 - packages/core/watcher/package.json | 2 +- packages/dev/babel-preset/package.json | 3 +- packages/resolvers/default/package.json | 4 ++ packages/transformers/terser/package.json | 4 ++ yarn.lock | 58 +++++++++++++++++++---- 6 files changed, 59 insertions(+), 13 deletions(-) diff --git a/packages/core/parcel-bundler/package.json b/packages/core/parcel-bundler/package.json index a1e92417223..4967fabcb6f 100644 --- a/packages/core/parcel-bundler/package.json +++ b/packages/core/parcel-bundler/package.json @@ -48,7 +48,6 @@ "dotenv-expand": "^4.2.0", "fast-glob": "^2.2.2", "filesize": "^3.6.0", - "fswatcher-child": "^1.0.5", "get-port": "^3.2.0", "htmlnano": "^0.1.9", "is-glob": "^4.0.0", diff --git a/packages/core/watcher/package.json b/packages/core/watcher/package.json index cf058bd9d77..cba10605106 100644 --- a/packages/core/watcher/package.json +++ b/packages/core/watcher/package.json @@ -17,7 +17,7 @@ "prepublish": "yarn build" }, "dependencies": { - "fswatcher-child": "^1.0.5" + "chokidar": "^2.0.4" }, "devDependencies": { "mocha": "^5.2.0", diff --git a/packages/dev/babel-preset/package.json b/packages/dev/babel-preset/package.json index b5040147e06..374f29cb81e 100644 --- a/packages/dev/babel-preset/package.json +++ b/packages/dev/babel-preset/package.json @@ -5,7 +5,8 @@ "dependencies": { "@babel/plugin-proposal-class-properties": "^7.1.0", "@babel/preset-env": "^7.1.0", - "@babel/preset-flow": "^7.0.0" + "@babel/preset-flow": "^7.0.0", + "read-pkg-up": "^4.0.0" }, "devDependencies": { "@babel/core": "^7.1.2" diff --git a/packages/resolvers/default/package.json b/packages/resolvers/default/package.json index 8b9d205bc3a..b609fca0499 100644 --- a/packages/resolvers/default/package.json +++ b/packages/resolvers/default/package.json @@ -15,6 +15,10 @@ "prepublish": "yarn build" }, "dependencies": { + "@parcel/fs": "^1.10.3", + "@parcel/plugin": "^2.0.0", + "@parcel/utils": "^1.10.3", + "micromatch": "^3.0.4", "node-libs-browser": "^2.1.0" }, "devDependencies": { diff --git a/packages/transformers/terser/package.json b/packages/transformers/terser/package.json index 92ea86b46d3..18a59ffc617 100644 --- a/packages/transformers/terser/package.json +++ b/packages/transformers/terser/package.json @@ -14,6 +14,10 @@ "build": "babel src -d lib", "prepublish": "yarn build" }, + "dependencies": { + "@parcel/plugin": "^2.0.0", + "terser": "^3.7.3" + }, "devDependencies": { "@parcel/eslint-config": "1.10.3" } diff --git a/yarn.lock b/yarn.lock index fb62e7cebce..d5f16c1cce8 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2223,7 +2223,7 @@ assign-symbols@^1.0.0: resolved "https://registry.yarnpkg.com/assign-symbols/-/assign-symbols-1.0.0.tgz#59667f41fadd4f20ccbc2bb96b8d4f7f78ec0367" integrity sha1-WWZ/QfrdTyDMvCu5a41Pf3jsA2c= -async-each@^1.0.0: +async-each@^1.0.0, async-each@^1.0.1: version "1.0.1" resolved "https://registry.yarnpkg.com/async-each/-/async-each-1.0.1.tgz#19d386a1d9edc6e7c1c85d388aedbcc56d33602d" integrity sha1-GdOGodntxufByF04iu28xW0zYC0= @@ -2911,7 +2911,7 @@ braces@^1.8.2: preserve "^0.2.0" repeat-element "^1.1.2" -braces@^2.3.0, braces@^2.3.1: +braces@^2.3.0, braces@^2.3.1, braces@^2.3.2: version "2.3.2" resolved "https://registry.yarnpkg.com/braces/-/braces-2.3.2.tgz#5979fd3f14cd531565e5fa2df1abfff1dfaee729" integrity sha512-aNdbnj9P8PjdXU4ybaWLK2IF3jc/EoDYbC7AazW6to3TRsfXxscC9UXOB5iDiEQrkyIbWp2SLQda4+QAa7nc3w== @@ -3323,6 +3323,25 @@ chokidar@^2.0.0, chokidar@^2.0.3: optionalDependencies: fsevents "^1.2.2" +chokidar@^2.0.4: + version "2.1.2" + resolved "https://registry.yarnpkg.com/chokidar/-/chokidar-2.1.2.tgz#9c23ea40b01638439e0513864d362aeacc5ad058" + integrity sha512-IwXUx0FXc5ibYmPC2XeEj5mpXoV66sR+t3jqu2NS2GYwCktt3KF1/Qqjws/NkegajBA4RbZ5+DDwlOiJsxDHEg== + dependencies: + anymatch "^2.0.0" + async-each "^1.0.1" + braces "^2.3.2" + glob-parent "^3.1.0" + inherits "^2.0.3" + is-binary-path "^1.0.0" + is-glob "^4.0.0" + normalize-path "^3.0.0" + path-is-absolute "^1.0.0" + readdirp "^2.2.1" + upath "^1.1.0" + optionalDependencies: + fsevents "^1.2.7" + chownr@^1.0.1: version "1.1.1" resolved "https://registry.yarnpkg.com/chownr/-/chownr-1.1.1.tgz#54726b8b8fff4df053c42187e801fb4412df1494" @@ -5354,6 +5373,14 @@ fsevents@^1.2.2: nan "^2.9.2" node-pre-gyp "^0.10.0" +fsevents@^1.2.7: + version "1.2.7" + resolved "https://registry.yarnpkg.com/fsevents/-/fsevents-1.2.7.tgz#4851b664a3783e52003b3c66eb0eee1074933aa4" + integrity sha512-Pxm6sI2MeBD7RdD12RYsqaP0nMiwx8eZBXCa6z2L+mRHm2DYrOYwihmhjpkdjUHwQhslWQjRpEgNq4XvBmaAuw== + dependencies: + nan "^2.9.2" + node-pre-gyp "^0.10.0" + "fstream@>= 0.1.30 < 1": version "0.1.31" resolved "https://registry.yarnpkg.com/fstream/-/fstream-0.1.31.tgz#7337f058fbbbbefa8c9f561a28cab0849202c988" @@ -5374,13 +5401,6 @@ fstream@^1.0.0, fstream@^1.0.2: mkdirp ">=0.5 0" rimraf "2" -fswatcher-child@^1.0.5: - version "1.1.1" - resolved "https://registry.yarnpkg.com/fswatcher-child/-/fswatcher-child-1.1.1.tgz#264dd95f9c4b5f8615327d7d7567884591846b9b" - integrity sha512-FVDjVhR71TkJ+ud6vnRwCHvCgK9drGRdimWcTLqw8iN88uL5tTX+/xrwigJdcuQGrWYo3TRw9gRzk9xqR0UPPQ== - dependencies: - chokidar "^2.0.3" - function-bind@^1.0.2, function-bind@^1.1.0, function-bind@^1.1.1: version "1.1.1" resolved "https://registry.yarnpkg.com/function-bind/-/function-bind-1.1.1.tgz#a56899d3ea3c9bab874bb9773b7c5ede92f4895d" @@ -8036,6 +8056,11 @@ normalize-path@^2.0.1, normalize-path@^2.1.1: dependencies: remove-trailing-separator "^1.0.1" +normalize-path@^3.0.0: + version "3.0.0" + resolved "https://registry.yarnpkg.com/normalize-path/-/normalize-path-3.0.0.tgz#0dcd69ff23a1c9b11fd0978316644a0388216a65" + integrity sha512-6eZs5Ls3WtCisHWp9S2GUy8dqkpGi4BVSz3GaqiE6ezub0512ESztXUwUB6C6IKbQkY2Pnb/mD4WYojCRwcwLA== + normalize-range@^0.1.2: version "0.1.2" resolved "https://registry.yarnpkg.com/normalize-range/-/normalize-range-0.1.2.tgz#2d10c06bdfd312ea9777695a4d28439456b75942" @@ -9822,6 +9847,14 @@ read-pkg-up@^3.0.0: find-up "^2.0.0" read-pkg "^3.0.0" +read-pkg-up@^4.0.0: + version "4.0.0" + resolved "https://registry.yarnpkg.com/read-pkg-up/-/read-pkg-up-4.0.0.tgz#1b221c6088ba7799601c808f91161c66e58f8978" + integrity sha512-6etQSH7nJGsK0RbG/2TeDzZFa8shjQ1um+SwQQ5cwKy0dhSXdOncEhb1CPpvQG4h7FyOV6EB6YlV0yJvZQNAkA== + dependencies: + find-up "^3.0.0" + read-pkg "^3.0.0" + read-pkg@^1.0.0, read-pkg@^1.1.0: version "1.1.0" resolved "https://registry.yarnpkg.com/read-pkg/-/read-pkg-1.1.0.tgz#f5ffaa5ecd29cb31c0474bca7d756b6bb29e3f28" @@ -9889,7 +9922,7 @@ readdir-scoped-modules@^1.0.0: graceful-fs "^4.1.2" once "^1.3.0" -readdirp@^2.0.0: +readdirp@^2.0.0, readdirp@^2.2.1: version "2.2.1" resolved "https://registry.yarnpkg.com/readdirp/-/readdirp-2.2.1.tgz#0e87622a3325aa33e892285caf8b4e846529a525" integrity sha512-1JU/8q+VgFZyxwrJ+SVIOsh+KywWGpds3NTqikiKpDMZWScmAYyKIgqkO+ARvNWJfXeXR1zxz7aHF4u4CyH6vQ== @@ -11444,6 +11477,11 @@ upath@^1.0.5: resolved "https://registry.yarnpkg.com/upath/-/upath-1.1.0.tgz#35256597e46a581db4793d0ce47fa9aebfc9fabd" integrity sha512-bzpH/oBhoS/QI/YtbkqCg6VEiPYjSZtrHQM6/QnJS6OL9pKUFLqb3aFh4Scvwm45+7iAgiMkLhSbaZxUqmrprw== +upath@^1.1.0: + version "1.1.2" + resolved "https://registry.yarnpkg.com/upath/-/upath-1.1.2.tgz#3db658600edaeeccbe6db5e684d67ee8c2acd068" + integrity sha512-kXpym8nmDmlCBr7nKdIx8P2jNBa+pBpIUFRnKJ4dr8htyYGJFokkr2ZvERRtUN+9SY+JqXouNgUPtv6JQva/2Q== + urix@^0.1.0: version "0.1.0" resolved "https://registry.yarnpkg.com/urix/-/urix-0.1.0.tgz#da937f7a62e21fec1fd18d49b35c2935067a6c72" From 66ffa053b8b0f3d82bb08a689f2925bfe8dea7e1 Mon Sep 17 00:00:00 2001 From: Will Binns-Smith Date: Wed, 13 Mar 2019 14:18:05 -0700 Subject: [PATCH 4/8] Add missing dependencies for utils --- packages/core/core/package.json | 2 -- packages/core/utils/package.json | 17 ++++++++++++++++- 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/packages/core/core/package.json b/packages/core/core/package.json index 9fb1edbe347..4a94aebdcc2 100644 --- a/packages/core/core/package.json +++ b/packages/core/core/package.json @@ -21,13 +21,11 @@ "abortcontroller-polyfill": "^1.1.9", "chalk": "^2.1.0", "commander": "^2.11.0", - "graphviz": "^0.0.8", "minimatch": "^3.0.4", "nullthrows": "^1.1.1", "p-queue": "^2.4.2", "pretty-format": "^23.5.0", "resolve-from": "^4.0.0", - "tempy": "^0.2.1", "v8-compile-cache": "^2.0.0" }, "devDependencies": { diff --git a/packages/core/utils/package.json b/packages/core/utils/package.json index e8bdea66d6d..a4df25276c3 100644 --- a/packages/core/utils/package.json +++ b/packages/core/utils/package.json @@ -20,9 +20,24 @@ "prepublish": "yarn build" }, "dependencies": { + "@iarna/toml": "^2.2.0", "@parcel/fs": "^1.10.3", + "@parcel/logger": "^1.10.3", "@parcel/workers": "^1.10.3", - "nullthrows": "^1.1.1" + "clone": "^2.1.1", + "command-exists": "^1.2.6", + "cross-spawn": "^6.0.4", + "deasync": "^0.1.14", + "fast-glob": "^2.2.2", + "graphviz": "^0.0.8", + "is-glob": "^4.0.0", + "is-url": "^1.2.2", + "json5": "^1.0.1", + "nullthrows": "^1.1.1", + "resolve": "^1.4.0", + "serialize-to-js": "^1.1.1", + "tempy": "^0.2.1", + "terser": "^3.7.3" }, "devDependencies": { "@babel/plugin-transform-flow-strip-types": "^7.2.0" From 1603b8621f4964b41981c31fa97378cdcf34868c Mon Sep 17 00:00:00 2001 From: Will Binns-Smith Date: Wed, 13 Mar 2019 14:44:13 -0700 Subject: [PATCH 5/8] Add missing dependencies for core, cache, logger, default bundler, and integration tests --- packages/bundlers/default/package.json | 3 ++- packages/core/cache/package.json | 5 +++++ packages/core/core/package.json | 15 ++++++++++++++- packages/core/integration-tests/package.json | 4 ++++ packages/core/logger/package.json | 11 ++++++----- 5 files changed, 31 insertions(+), 7 deletions(-) diff --git a/packages/bundlers/default/package.json b/packages/bundlers/default/package.json index 1a00719bb50..a24850687b6 100644 --- a/packages/bundlers/default/package.json +++ b/packages/bundlers/default/package.json @@ -11,7 +11,8 @@ "parcel": "2.x" }, "dependencies": { - "@parcel/plugin": "^2.0.0" + "@parcel/plugin": "^2.0.0", + "@parcel/utils": "^1.10.3" }, "devDependencies": { "@parcel/eslint-config": "^1.10.3" diff --git a/packages/core/cache/package.json b/packages/core/cache/package.json index c8536603911..5d2c288f693 100644 --- a/packages/core/cache/package.json +++ b/packages/core/cache/package.json @@ -11,6 +11,11 @@ "build": "babel src --out-dir lib", "prepublish": "yarn build" }, + "dependencies": { + "@parcel/fs": "^1.10.3", + "@parcel/logger": "^1.10.3", + "@parcel/utils": "^1.10.3" + }, "devDependencies": { "@parcel/eslint-config": "1.10.3" } diff --git a/packages/core/core/package.json b/packages/core/core/package.json index 4a94aebdcc2..f575a5e068f 100644 --- a/packages/core/core/package.json +++ b/packages/core/core/package.json @@ -15,24 +15,37 @@ "dependencies": { "@parcel/cache": "^2.0.0", "@parcel/config-default": "^2.0.0", + "@parcel/fs": "^1.10.3", + "@parcel/logger": "^1.10.3", "@parcel/plugin": "^2.0.0", "@parcel/types": "^2.0.0", "@parcel/utils": "^1.10.3", + "@parcel/watcher": "^1.10.3", + "@parcel/workers": "^1.10.3", "abortcontroller-polyfill": "^1.1.9", + "browserslist": "^4.1.0", "chalk": "^2.1.0", + "clone": "^2.1.1", "commander": "^2.11.0", + "dotenv": "^5.0.0", + "dotenv-expand": "^4.2.0", + "json5": "^1.0.1", + "micromatch": "^3.0.4", "minimatch": "^3.0.4", "nullthrows": "^1.1.1", "p-queue": "^2.4.2", "pretty-format": "^23.5.0", "resolve-from": "^4.0.0", + "semver": "^5.4.1", "v8-compile-cache": "^2.0.0" }, "devDependencies": { "@parcel/babel-register": "2.0.0", "@parcel/eslint-config": "1.10.3", + "@parcel/logger": "1.10.3", "delay": "^4.1.0", - "random-int": "^1.0.0" + "random-int": "^1.0.0", + "sinon": "^5.0.1" }, "bin": { "parcel": "bin.js" diff --git a/packages/core/integration-tests/package.json b/packages/core/integration-tests/package.json index b2aae36e45b..e42f4eb1ca0 100644 --- a/packages/core/integration-tests/package.json +++ b/packages/core/integration-tests/package.json @@ -13,8 +13,12 @@ }, "devDependencies": { "@babel/core": "^7.2.0", + "@parcel/config-default": "^2.0.0", + "@parcel/core": "^2.0.0", "@parcel/fs": "^1.10.3", "@parcel/test-utils": "^1.10.3", + "@parcel/utils": "^1.10.3", + "chalk": "^2.1.0", "codecov": "^3.0.0", "command-exists": "^1.2.6", "graphql-tag": "^2.6.0", diff --git a/packages/core/logger/package.json b/packages/core/logger/package.json index 82eb6dda174..3595c35d114 100644 --- a/packages/core/logger/package.json +++ b/packages/core/logger/package.json @@ -19,15 +19,16 @@ "build": "babel src -d lib", "prepublish": "yarn build" }, - "devDependencies": { - "@parcel/eslint-config": "1.10.3", - "mocha": "^5.2.0", - "sinon": "^5.0.1" - }, "dependencies": { + "@parcel/workers": "^1.10.3", "chalk": "^2.1.0", "grapheme-breaker": "^0.3.2", "ora": "^2.1.0", "strip-ansi": "^4.0.0" + }, + "devDependencies": { + "@parcel/eslint-config": "1.10.3", + "mocha": "^5.2.0", + "sinon": "^5.0.1" } } From 8d84dc7c73494fc4b92272cb5d2a318e8f6cfafa Mon Sep 17 00:00:00 2001 From: Will Binns-Smith Date: Wed, 13 Mar 2019 14:46:09 -0700 Subject: [PATCH 6/8] @parcel/register: reference locally --- packages/core/register/example/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/register/example/index.js b/packages/core/register/example/index.js index 74c2c922488..b9c22e11d73 100644 --- a/packages/core/register/example/index.js +++ b/packages/core/register/example/index.js @@ -1,4 +1,4 @@ -require('@parcel/register'); +require('../'); const count = require('./count.js'); const number = require('./number.js'); From fa3bb813ae763786a8ec8dd9648d71c91244145d Mon Sep 17 00:00:00 2001 From: Will Binns-Smith Date: Wed, 13 Mar 2019 14:46:50 -0700 Subject: [PATCH 7/8] Add eslint-plugin-import and enforce every import has a package json entry --- .eslintignore | 1 + packages/dev/eslint-config/index.js | 7 +- packages/dev/eslint-config/package.json | 3 +- yarn.lock | 86 +++++++++++++++++++++++++ 4 files changed, 95 insertions(+), 2 deletions(-) diff --git a/.eslintignore b/.eslintignore index cea56e3403a..8eafdc0a25c 100644 --- a/.eslintignore +++ b/.eslintignore @@ -7,6 +7,7 @@ flow-typed packages/*/*/test/integration/** packages/*/*/test/mochareporters.json +packages/core/integration-tests/test/input/** packages/examples/simple/** # Generated by the build diff --git a/packages/dev/eslint-config/index.js b/packages/dev/eslint-config/index.js index 18a78948a5c..f362137ba56 100644 --- a/packages/dev/eslint-config/index.js +++ b/packages/dev/eslint-config/index.js @@ -1,7 +1,7 @@ module.exports = { extends: ['eslint:recommended', 'plugin:flowtype/recommended'], parser: 'babel-eslint', - plugins: ['flowtype'], + plugins: ['flowtype', 'import'], parserOptions: { ecmaVersion: 8, ecmaFeatures: { @@ -15,5 +15,10 @@ module.exports = { globals: { parcelRequire: true, define: true + }, + rules: { + 'import/first': 'error', + 'import/no-extraneous-dependencies': 'error', + 'import/no-self-import': 'error' } }; diff --git a/packages/dev/eslint-config/package.json b/packages/dev/eslint-config/package.json index 9b61317e242..18ed9753335 100644 --- a/packages/dev/eslint-config/package.json +++ b/packages/dev/eslint-config/package.json @@ -3,6 +3,7 @@ "version": "1.10.3", "dependencies": { "babel-eslint": "^10.0.1", - "eslint-plugin-flowtype": "^3.1.1" + "eslint-plugin-flowtype": "^3.1.1", + "eslint-plugin-import": "^2.16.0" } } diff --git a/yarn.lock b/yarn.lock index d5f16c1cce8..58a74374437 100644 --- a/yarn.lock +++ b/yarn.lock @@ -3690,6 +3690,11 @@ constants-browserify@^1.0.0: resolved "https://registry.yarnpkg.com/constants-browserify/-/constants-browserify-1.0.0.tgz#c20b96d8c617748aaf1c16021760cd27fcb8cb75" integrity sha1-wguW2MYXdIqvHBYCF2DNJ/y4y3U= +contains-path@^0.1.0: + version "0.1.0" + resolved "https://registry.yarnpkg.com/contains-path/-/contains-path-0.1.0.tgz#fe8cf184ff6670b6baef01a9d4861a5cbec4120a" + integrity sha1-/ozxhP9mcLa67wGp1IYaXL7EEgo= + conventional-changelog-angular@^5.0.1: version "5.0.1" resolved "https://registry.yarnpkg.com/conventional-changelog-angular/-/conventional-changelog-angular-5.0.1.tgz#f96431b76de453333a909decd02b15cb5bd2d364" @@ -4495,6 +4500,14 @@ dir-glob@^2.0.0: arrify "^1.0.1" path-type "^3.0.0" +doctrine@1.5.0: + version "1.5.0" + resolved "https://registry.yarnpkg.com/doctrine/-/doctrine-1.5.0.tgz#379dce730f6166f76cefa4e6707a159b02c5a6fa" + integrity sha1-N53Ocw9hZvds76TmcHoVmwLFpvo= + dependencies: + esutils "^2.0.2" + isarray "^1.0.0" + doctrine@^2.1.0: version "2.1.0" resolved "https://registry.yarnpkg.com/doctrine/-/doctrine-2.1.0.tgz#5cd01fc101621b42c4cd7f5d1a66243716d3f39d" @@ -4780,6 +4793,22 @@ escodegen@~1.9.0: optionalDependencies: source-map "~0.6.1" +eslint-import-resolver-node@^0.3.2: + version "0.3.2" + resolved "https://registry.yarnpkg.com/eslint-import-resolver-node/-/eslint-import-resolver-node-0.3.2.tgz#58f15fb839b8d0576ca980413476aab2472db66a" + integrity sha512-sfmTqJfPSizWu4aymbPr4Iidp5yKm8yDkHp+Ir3YiTHiiDfxh69mOUsmiqW6RZ9zRXFaF64GtYmN7e+8GHBv6Q== + dependencies: + debug "^2.6.9" + resolve "^1.5.0" + +eslint-module-utils@^2.3.0: + version "2.3.0" + resolved "https://registry.yarnpkg.com/eslint-module-utils/-/eslint-module-utils-2.3.0.tgz#546178dab5e046c8b562bbb50705e2456d7bda49" + integrity sha512-lmDJgeOOjk8hObTysjqH7wyMi+nsHwwvfBykwfhjR1LNdd7C2uFJBvx4OpWYpXOw4df1yE1cDEVd1yLHitk34w== + dependencies: + debug "^2.6.8" + pkg-dir "^2.0.0" + eslint-plugin-flowtype@^3.1.1: version "3.1.1" resolved "https://registry.yarnpkg.com/eslint-plugin-flowtype/-/eslint-plugin-flowtype-3.1.1.tgz#1b96559b8015c06e6b7a3c5ba9c73d8e652e69d8" @@ -4787,6 +4816,22 @@ eslint-plugin-flowtype@^3.1.1: dependencies: lodash "^4.17.10" +eslint-plugin-import@^2.16.0: + version "2.16.0" + resolved "https://registry.yarnpkg.com/eslint-plugin-import/-/eslint-plugin-import-2.16.0.tgz#97ac3e75d0791c4fac0e15ef388510217be7f66f" + integrity sha512-z6oqWlf1x5GkHIFgrSvtmudnqM6Q60KM4KvpWi5ubonMjycLjndvd5+8VAZIsTlHC03djdgJuyKG6XO577px6A== + dependencies: + contains-path "^0.1.0" + debug "^2.6.9" + doctrine "1.5.0" + eslint-import-resolver-node "^0.3.2" + eslint-module-utils "^2.3.0" + has "^1.0.3" + lodash "^4.17.11" + minimatch "^3.0.4" + read-pkg-up "^2.0.0" + resolve "^1.9.0" + eslint-plugin-react@^7.12.0: version "7.12.0" resolved "https://registry.yarnpkg.com/eslint-plugin-react/-/eslint-plugin-react-7.12.0.tgz#fa6701063f2172c3e1db3a22d3db6d8bdc0179af" @@ -7032,6 +7077,16 @@ load-json-file@^1.0.0: pinkie-promise "^2.0.0" strip-bom "^2.0.0" +load-json-file@^2.0.0: + version "2.0.0" + resolved "https://registry.yarnpkg.com/load-json-file/-/load-json-file-2.0.0.tgz#7947e42149af80d696cbf797bcaabcfe1fe29ca8" + integrity sha1-eUfkIUmvgNaWy/eXvKq8/h/inKg= + dependencies: + graceful-fs "^4.1.2" + parse-json "^2.2.0" + pify "^2.0.0" + strip-bom "^3.0.0" + load-json-file@^4.0.0: version "4.0.0" resolved "https://registry.yarnpkg.com/load-json-file/-/load-json-file-4.0.0.tgz#2f5f45ab91e33216234fd53adab668eb4ec0993b" @@ -8693,6 +8748,13 @@ path-type@^1.0.0: pify "^2.0.0" pinkie-promise "^2.0.0" +path-type@^2.0.0: + version "2.0.0" + resolved "https://registry.yarnpkg.com/path-type/-/path-type-2.0.0.tgz#f012ccb8415b7096fc2daa1054c3d72389594c73" + integrity sha1-8BLMuEFbcJb8LaoQVMPXI4lZTHM= + dependencies: + pify "^2.0.0" + path-type@^3.0.0: version "3.0.0" resolved "https://registry.yarnpkg.com/path-type/-/path-type-3.0.0.tgz#cef31dc8e0a1a3bb0d105c0cd97cf3bf47f4e36f" @@ -9839,6 +9901,14 @@ read-pkg-up@^1.0.1: find-up "^1.0.0" read-pkg "^1.0.0" +read-pkg-up@^2.0.0: + version "2.0.0" + resolved "https://registry.yarnpkg.com/read-pkg-up/-/read-pkg-up-2.0.0.tgz#6b72a8048984e0c41e79510fd5e9fa99b3b549be" + integrity sha1-a3KoBImE4MQeeVEP1en6mbO1Sb4= + dependencies: + find-up "^2.0.0" + read-pkg "^2.0.0" + read-pkg-up@^3.0.0: version "3.0.0" resolved "https://registry.yarnpkg.com/read-pkg-up/-/read-pkg-up-3.0.0.tgz#3ed496685dba0f8fe118d0691dc51f4a1ff96f07" @@ -9864,6 +9934,15 @@ read-pkg@^1.0.0, read-pkg@^1.1.0: normalize-package-data "^2.3.2" path-type "^1.0.0" +read-pkg@^2.0.0: + version "2.0.0" + resolved "https://registry.yarnpkg.com/read-pkg/-/read-pkg-2.0.0.tgz#8ef1c0623c6a6db0dc6713c4bfac46332b2368f8" + integrity sha1-jvHAYjxqbbDcZxPEv6xGMysjaPg= + dependencies: + load-json-file "^2.0.0" + normalize-package-data "^2.3.2" + path-type "^2.0.0" + read-pkg@^3.0.0: version "3.0.0" resolved "https://registry.yarnpkg.com/read-pkg/-/read-pkg-3.0.0.tgz#9cbc686978fee65d16c00e2b19c237fcf6e38389" @@ -10209,6 +10288,13 @@ resolve@^1.1.5: dependencies: path-parse "^1.0.5" +resolve@^1.5.0: + version "1.10.0" + resolved "https://registry.yarnpkg.com/resolve/-/resolve-1.10.0.tgz#3bdaaeaf45cc07f375656dfd2e54ed0810b101ba" + integrity sha512-3sUr9aq5OfSg2S9pNtPA9hL1FVEAjvfOC4leW0SNf/mpnaakz2a9femSd6LqAww2RaFctwyf1lCqnTHuF1rxDg== + dependencies: + path-parse "^1.0.6" + resolve@^1.9.0: version "1.9.0" resolved "https://registry.yarnpkg.com/resolve/-/resolve-1.9.0.tgz#a14c6fdfa8f92a7df1d996cb7105fa744658ea06" From 8b8e900fee3c7f0b5d3092d9dbadc1f9c4388e11 Mon Sep 17 00:00:00 2001 From: Will Binns-Smith Date: Wed, 13 Mar 2019 15:32:26 -0700 Subject: [PATCH 8/8] Require newlines after requires. Fix existing --- packages/core/core/bin.js | 1 + packages/core/core/test/TransformerRunner.test.js | 1 + packages/core/integration-tests/test/utils.js | 1 + packages/core/parcel-bundler/src/assets/RustAsset.js | 1 + packages/core/parcel-bundler/src/transforms/babel/config.js | 1 + packages/core/parcel-bundler/test/autoinstall.js | 1 + packages/core/parcel-bundler/test/utils.js | 1 + packages/dev/eslint-config/index.js | 1 + 8 files changed, 8 insertions(+) diff --git a/packages/core/core/bin.js b/packages/core/core/bin.js index 8d5ad27f3ce..3526f22a376 100755 --- a/packages/core/core/bin.js +++ b/packages/core/core/bin.js @@ -13,6 +13,7 @@ let cliOpts = { watch: program.watch }; let Parcel = require('.').default; + let parcel = new Parcel({ entries, cliOpts diff --git a/packages/core/core/test/TransformerRunner.test.js b/packages/core/core/test/TransformerRunner.test.js index 681953df920..4b95b53d650 100644 --- a/packages/core/core/test/TransformerRunner.test.js +++ b/packages/core/core/test/TransformerRunner.test.js @@ -4,6 +4,7 @@ import Config from '../src/Config'; import Environment from '../src/Environment'; const config = require('@parcel/config-default'); + const runner = new TransformerRunner({ config: new Config(config, require.resolve('@parcel/config-default')), cliOpts: {} diff --git a/packages/core/integration-tests/test/utils.js b/packages/core/integration-tests/test/utils.js index f8a11ec6077..a2e53b37b81 100644 --- a/packages/core/integration-tests/test/utils.js +++ b/packages/core/integration-tests/test/utils.js @@ -14,6 +14,7 @@ const {sleep} = require('@parcel/test-utils'); const defaultConfig = require('@parcel/config-default'); const chalk = new (require('chalk')).constructor({enabled: true}); + const warning = chalk.keyword('orange'); // eslint-disable-next-line no-console console.warn = (...args) => { diff --git a/packages/core/parcel-bundler/src/assets/RustAsset.js b/packages/core/parcel-bundler/src/assets/RustAsset.js index 25124b5c70f..117f565de8b 100644 --- a/packages/core/parcel-bundler/src/assets/RustAsset.js +++ b/packages/core/parcel-bundler/src/assets/RustAsset.js @@ -2,6 +2,7 @@ const path = require('path'); const commandExists = require('command-exists'); const childProcess = require('child_process'); const {promisify} = require('@parcel/utils'); + const exec = promisify(childProcess.execFile); const toml = require('@iarna/toml'); const fs = require('@parcel/fs'); diff --git a/packages/core/parcel-bundler/src/transforms/babel/config.js b/packages/core/parcel-bundler/src/transforms/babel/config.js index cc48de65fdb..11b5b1135bf 100644 --- a/packages/core/parcel-bundler/src/transforms/babel/config.js +++ b/packages/core/parcel-bundler/src/transforms/babel/config.js @@ -7,6 +7,7 @@ const fs = require('@parcel/fs'); const NODE_MODULES = `${path.sep}node_modules${path.sep}`; const ENV_PLUGINS = require('@babel/preset-env/data/plugins'); + const ENV_PRESETS = { es2015: true, es2016: true, diff --git a/packages/core/parcel-bundler/test/autoinstall.js b/packages/core/parcel-bundler/test/autoinstall.js index 0aa5b8fb098..5603695fb1a 100644 --- a/packages/core/parcel-bundler/test/autoinstall.js +++ b/packages/core/parcel-bundler/test/autoinstall.js @@ -3,6 +3,7 @@ const install = require('../src/utils/installPackage'); const fs = require('@parcel/fs'); const {ncp, rimraf} = require('./utils'); const path = require('path'); + const inputDirPath = path.join(__dirname, '/input'); describe('autoinstall', function() { diff --git a/packages/core/parcel-bundler/test/utils.js b/packages/core/parcel-bundler/test/utils.js index f844538007c..58bb40c4c99 100644 --- a/packages/core/parcel-bundler/test/utils.js +++ b/packages/core/parcel-bundler/test/utils.js @@ -13,6 +13,7 @@ const rimraf = promisify(require('rimraf')); const ncp = promisify(require('ncp')); const chalk = new (require('chalk')).constructor({enabled: true}); + const warning = chalk.keyword('orange'); // eslint-disable-next-line no-console console.warn = (...args) => { diff --git a/packages/dev/eslint-config/index.js b/packages/dev/eslint-config/index.js index f362137ba56..4cc049af3a9 100644 --- a/packages/dev/eslint-config/index.js +++ b/packages/dev/eslint-config/index.js @@ -18,6 +18,7 @@ module.exports = { }, rules: { 'import/first': 'error', + 'import/newline-after-import': 'error', 'import/no-extraneous-dependencies': 'error', 'import/no-self-import': 'error' }