Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.pug file change does not trigger page reload #2090

Closed
dum3ng opened this issue Oct 2, 2018 · 2 comments
Closed

.pug file change does not trigger page reload #2090

dum3ng opened this issue Oct 2, 2018 · 2 comments

Comments

@dum3ng
Copy link

dum3ng commented Oct 2, 2018

馃悰 bug report

change a .pug file should trigger page reload.

馃帥 Configuration (.babelrc, package.json, cli command)

no configuration.

馃 Expected Behavior

1, use parcel index.pug
2, edit index.pug and save.
The browser should automatically reload the page.

馃槸 Current Behavior

When the entry point is html type, the page reload works. But that does not work
for a pug file type.

馃拋 Possible Solution

For now I use 'parcel watch index.pug' and use another watch server, but I think parcel should
handle this natively.

馃捇 Code Sample

index.pug

<!DOCTYPE html>
html(lang="en")
  head
    meta(charset="UTF-8")
    meta(name="viewport", content="width=device-width, initial-scale=1.0")
    meta(http-equiv="X-UA-Compatible", content="ie=edge")
    title Document
  body
    h2 should update in browser after edit me 
    script(src="./ts/play.ts")

./ts/play.ts

console.log('parcel with pug');

馃實 Your Environment

Software Version(s)
Parcel 1.10.1
Node 10.11.0
Yarn 1.10.1
Operating System macos mojave 10.14
@Ty3uK Ty3uK mentioned this issue Oct 2, 2018
Merged
3 tasks
@Ty3uK
Copy link
Contributor

Ty3uK commented Oct 2, 2018 •
edited

@dum3ng will be fixed in #2091 when PR is accepted

DeMoorJasper pushed a commit that referenced this issue Oct 2, 2018
@Ty3uK @DeMoorJasper
Fix HMR for Pug assets (#2091)
b292407 
---
name: 馃檵 Fix HMR for Pug assets
---

<!---
Thanks for filing a pull request 馃槃 ! Before you submit, please read the following:

Search open/closed issues before submitting since someone might have pushed the same thing before!
-->
## 鈫笍 Pull Request
<!---
Provide a general summary of the pull request here
Does this address an existing issue?
-->
#2090

## 馃捇 Examples

<!-- Examples help us understand the requested feature better -->

## 鉁旓笍 PR Todo

- [ ] Added/updated unit tests for this change
- [ ] Filled out test instructions
- [x] Included links to related issues/PRs
<!-- Love parcel? Please consider supporting our collective:
馃憠  https://opencollective.com/parcel/donate -->
@Ty3uK
Copy link
Contributor

Ty3uK commented Oct 2, 2018

@dum3ng PR is merged, check it out!

devongovett pushed a commit that referenced this issue Oct 15, 2018
@Ty3uK @DeMoorJasper
Fix HMR for Pug assets (#2091)
0847888 
---
name: 馃檵 Fix HMR for Pug assets
---

<!---
Thanks for filing a pull request 馃槃 ! Before you submit, please read the following:

Search open/closed issues before submitting since someone might have pushed the same thing before!
-->
## 鈫笍 Pull Request
<!---
Provide a general summary of the pull request here
Does this address an existing issue?
-->
#2090

## 馃捇 Examples

<!-- Examples help us understand the requested feature better -->

## 鉁旓笍 PR Todo

- [ ] Added/updated unit tests for this change
- [ ] Filled out test instructions
- [x] Included links to related issues/PRs
<!-- Love parcel? Please consider supporting our collective:
馃憠  https://opencollective.com/parcel/donate -->
devongovett pushed a commit that referenced this issue Oct 15, 2018
@Ty3uK @DeMoorJasper
Fix HMR for Pug assets (#2091)
030968c 
---
name: 馃檵 Fix HMR for Pug assets
---

<!---
Thanks for filing a pull request 馃槃 ! Before you submit, please read the following:

Search open/closed issues before submitting since someone might have pushed the same thing before!
-->
## 鈫笍 Pull Request
<!---
Provide a general summary of the pull request here
Does this address an existing issue?
-->
#2090

## 馃捇 Examples

<!-- Examples help us understand the requested feature better -->

## 鉁旓笍 PR Todo

- [ ] Added/updated unit tests for this change
- [ ] Filled out test instructions
- [x] Included links to related issues/PRs
<!-- Love parcel? Please consider supporting our collective:
馃憠  https://opencollective.com/parcel/donate -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DeMoorJasper @Ty3uK @dum3ng