Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI still fails with Node 6 on Windows. #2613

Closed
sainthkh opened this issue Feb 1, 2019 · 3 comments
Closed

CI still fails with Node 6 on Windows. #2613

sainthkh opened this issue Feb 1, 2019 · 3 comments

Comments

@sainthkh
Copy link
Contributor

sainthkh commented Feb 1, 2019

❔ Question

I fixed the Windows watcher.stop() test. And there is no problem with that. (#2609 #2612)

But CI still fails with Node 6 on Windows. You can see the single red circle in the middle of other green ones. According to console messages, it seems that the test failed somewhere when testing to auto-install babel and other dependencies.

Now, here's the question:

The support for Node 6 ends on April 2019. In other words, it's less than 100 days and a little more than 2 months.

I can install Node 6 and track problems. But I don't think it's a good idea for me to spend time to support old and rare systems.

How about removing Node 6 tests from our CI?

🔦 Context

CI fails on Windows + Node 6. And it can confuse new contributors.

💻 Code Sample

Azure CI result

🌍 Your Environment

N/A

@sainthkh
Copy link
Contributor Author

sainthkh commented Feb 1, 2019

In #2612 result, there are failures in Linux Node 6 and Windows Node 8 after request to localhost.

The message says that they failed because of timeout.

Error message below:

Error: Timeout of 50000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (D:\a\1\s\packages\core\integration-tests\test\hmr.js)

@devongovett
Copy link
Member

We are dropping Node 6 in Parcel 2, but until then we should continue to support it or it would be a breaking change.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs.

@github-actions github-actions bot added the Stale Inactive issues label Jan 17, 2020
@github-actions github-actions bot closed this as completed Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants