You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Runtime-js currently has specific support for chrome and firefox extensions. It has logic to generate a url relative to the bundle root. For Safari this logic is missing, and parcel generates non-functional URLs. (could be considered a bug, depending on how you look at it)
馃 Expected Behavior
When accessing assets in a safari extension, URLs should be formed correctly by getBundleUrl/getBaseUrl/getOrigin.
馃槸 Current Behavior
URLs generated by getBundleUrl/getBaseUrl/getOrigin do not get transformed and are not generally resolvable in a safari extension.
馃拋 Possible Solution
Adapt the regex in bundle-url.js to also support safari extensions.
I wrote a fix here: 6b82317
The text was updated successfully, but these errors were encountered:
Feel free to make a PR with that commit! We have only tested that regex on Chrome and Firefox extensions, but I think pretty much every major browser beyond Firefox uses Chromium at this point so they all use chrome-extension. I guess Safari made their own implementation though.
馃檵 feature request
Runtime-js currently has specific support for chrome and firefox extensions. It has logic to generate a url relative to the bundle root. For Safari this logic is missing, and parcel generates non-functional URLs. (could be considered a bug, depending on how you look at it)
馃 Expected Behavior
When accessing assets in a safari extension, URLs should be formed correctly by getBundleUrl/getBaseUrl/getOrigin.
馃槸 Current Behavior
URLs generated by getBundleUrl/getBaseUrl/getOrigin do not get transformed and are not generally resolvable in a safari extension.
馃拋 Possible Solution
Adapt the regex in bundle-url.js to also support safari extensions.
I wrote a fix here: 6b82317
The text was updated successfully, but these errors were encountered: