Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animated gifs stopped working upgrading to 2.6.2 #8328

Closed
dioptre opened this issue Jul 20, 2022 · 5 comments
Closed

Animated gifs stopped working upgrading to 2.6.2 #8328

dioptre opened this issue Jul 20, 2022 · 5 comments
Labels
Stale Inactive issues

Comments

@dioptre
Copy link

dioptre commented Jul 20, 2022

Using https://parceljs.org/recipes/image/

All of our images started cropping when using width/height changes and webp

Going to leave this as a footnote for now to see if it has effected anyone else.

Will report back soon.

@mischnic
Copy link
Member

Nothing really changed in Parcel, maybe sharp did some breaking change?

@dioptre
Copy link
Author

dioptre commented Jul 22, 2022

Ok thanks @mischnic

Seems like something weird changed since 2.3.0 (we are on 2.6.2 now) maybe something to do with:

#8018

So it turns out animated GIFs are not working as expected. In version 2.3.0 we were able to specify:

import Image from '../../img/spinner.gif?as=webp&width=50&height=50' (this breaks in 2.6.2!!!)

While confusingly this is ok still:

import Image from '../../img/spinner.gif?as=webp' (this is ok!)

And the spinner animated fine at the new size, and now it doesn't work. I tried reverting the change by @Commandtechno but it still breaks,
bb923d6

So might be todo with the blob/streaming stuff @devongovett added above.

Can live with it, just a shame to have an upgrade that works less well than the earlier version.

Thanks

@dioptre dioptre changed the title Resizing images started cropping instead of resizing to fit, and all the images changed upgrading to 2.6.2 Animated gifs stopped working upgrading to 2.6.2 Jul 22, 2022
@mischnic
Copy link
Member

So reverting bb923d6 apparently causes a different behaviour regarding cropping/repeat.

For me, both Parcel versions (2.3.0 and 2.6.2) remove the animation when specifying width or height.

So might be todo with the blob/streaming stuff devongovett added above.

What change are you referring to?

@dioptre
Copy link
Author

dioptre commented Jul 27, 2022

@mischnic
https://github.com/parcel-bundler/parcel/commits/v2/packages/transformers/image/src

I tried with an earlier version of sharp but didn't seem to fix either :/ so not sure yet why it broke

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs.

@github-actions github-actions bot added the Stale Inactive issues label Jan 24, 2023
@github-actions github-actions bot closed this as completed Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Inactive issues
Projects
None yet
Development

No branches or pull requests

2 participants