Prevent nameclashes with internal variables #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
devongovett
reviewed
Jul 16, 2018
src/scope-hoisting/hoist.js
Outdated
| @@ -121,7 +121,7 @@ module.exports = { | |||
| // Rename each binding in the top-level scope to something unique. | |||
| for (let name in scope.bindings) { | |||
| if (!name.startsWith('$' + t.toIdentifier(asset.id))) { | |||
| let newName = getName(asset, 'var', name); | |||
| let newName = getName(asset, 'var', name, '$'); | |||
There was a problem hiding this comment.
I don't think this should clash with anything. This would generate e.g. $id$var$exports vs our internal which is just $id$exports. Seems like the problem might be something else though I'm not sure why this would fix it...
|
Turns out the regex matching exports variables was wrong. Fixed it. |
devongovett
approved these changes
Jul 16, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1699
Found in
core-jscode