Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to Dart-Sass and add backwards compatibility for node-sass #1847

Merged
merged 2 commits into from Aug 16, 2018

Conversation

DeMoorJasper
Copy link
Member

@DeMoorJasper DeMoorJasper commented Aug 3, 2018

Dart sass will prevent parcel from randomly freezing.
It's also a lot stricter, preventing unknown errors or side-effects after compiling/parsing.
Also adds codeFrames, so users get a visual representation of the line the error occurs.

Closes #1836 Related to #1509

Copy link
Contributor

@fathyb fathyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat 🔥

@DeMoorJasper DeMoorJasper merged commit 70ce33b into master Aug 16, 2018
@DeMoorJasper DeMoorJasper deleted the feature/dart-sass branch August 16, 2018 15:52
@BBlackwo
Copy link

@DeMoorJasper should you also update the website?
https://parceljs.org/assets.html

@DeMoorJasper
Copy link
Member Author

DeMoorJasper commented Aug 16, 2018

@BBlackwo thanks for the heads up I'll make a pr in a bit

Sent with GitHawk

devongovett pushed a commit that referenced this pull request Oct 15, 2018
…1847)

Dart sass will prevent parcel from randomly freezing.
It's also a lot stricter, preventing unknown errors or side-effects after compiling/parsing.
Also adds codeFrames, so users get a visual representation of the line the error occurs.

Closes #1836 Related to #1509
devongovett pushed a commit that referenced this pull request Oct 15, 2018
…1847)

Dart sass will prevent parcel from randomly freezing.
It's also a lot stricter, preventing unknown errors or side-effects after compiling/parsing.
Also adds codeFrames, so users get a visual representation of the line the error occurs.

Closes #1836 Related to #1509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants