Fix infinite loop in resolver when using ~/... imports
#1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeMoorJasper
changed the title
~~
DeMoorJasper
changed the title
~~/... imports
fathyb
reviewed
Aug 16, 2018
src/Resolver.js
Outdated
| @@ -132,6 +132,11 @@ class Resolver { | |||
| path.basename(path.dirname(dir)) !== 'node_modules' | |||
| ) { | |||
| dir = path.dirname(dir); | |||
|
|
|||
| if (dir === '/') { | |||
There was a problem hiding this comment.
Will this work on Windows? What about if (dir === path.dirname(dir))?
There was a problem hiding this comment.
Probably a better idea. I'll update it.
Sidenote the resolver is already broken on windows.
There was a problem hiding this comment.
Oh, do you know if we're tracking this somewhere?
fathyb
approved these changes
Aug 17, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
~is being used outside of rootDir and node_modules, the resolver will freeze on an infinite loop.This PR changes it to fallback to rootDir, as that's probably the intended behaviour.
SideNote: FSWatcher Update just forces parcel to use 1.0.5, which fixes an issue with profiler