Don't resolve slash and tilde paths twice #1993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix "Cannot resolve dependency" error for valid slash and tilde paths
Before:
/src/js/index.js
-> /home/user/my-project/src/js/index.js
-> /home/user/my-project/home/user/my-project/src/js/index.js
Error:
Cannot resolve dependency /home/user/my-project/src/js/index.js
After:
/src/js/index.js
-> /home/user/my-project/src/js/index.js
the code already has a way for asset-handlers to signal to the bundler that a
dependency has been resolved to an absolute path, but it isn't being used
fixes #1555
fixes #1986
DeMoorJasper
approved these changes
Sep 6, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
Fix "Cannot resolve dependency" errors for valid slash and tilde paths.
Before:
/src/js/index.js
-> /home/user/my-project/src/js/index.js
-> /home/user/my-project/home/user/my-project/src/js/index.js
Error:
Cannot resolve dependency /home/user/my-project/src/js/index.js
After:
/src/js/index.js
-> /home/user/my-project/src/js/index.js
The code already has a way for asset-handlers to signal to the bundler that a dependency has been resolved to an absolute path, but it isn't being used.
fixes #1555
fixes #1986
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
Fix "Cannot resolve dependency" errors for valid slash and tilde paths.
Before:
/src/js/index.js
-> /home/user/my-project/src/js/index.js
-> /home/user/my-project/home/user/my-project/src/js/index.js
Error:
Cannot resolve dependency /home/user/my-project/src/js/index.js
After:
/src/js/index.js
-> /home/user/my-project/src/js/index.js
The code already has a way for asset-handlers to signal to the bundler that a dependency has been resolved to an absolute path, but it isn't being used.
fixes #1555
fixes #1986
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix "Cannot resolve dependency" errors for valid slash and tilde paths.
Before:
Error:
After:
The code already has a way for asset-handlers to signal to the bundler that a dependency has been resolved to an absolute path, but it isn't being used.
fixes #1555
fixes #1986