Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing --no-autoinstall flag to build command #2076

Merged
merged 1 commit into from Sep 28, 2018

Conversation

jamiebuilds
Copy link
Member

Was running parcel build and the auto installer started running, I went to disable it and found that the option was not available here

@DeMoorJasper DeMoorJasper merged commit c58dce8 into master Sep 28, 2018
@DeMoorJasper DeMoorJasper deleted the jamiebuilds-patch-1 branch September 28, 2018 19:34
@devongovett
Copy link
Member

hmm, I believe auto install is already disabled by default in production mode, that's why the --no-autoinstall option is not available there https://github.com/parcel-bundler/parcel/blob/master/src/Bundler.js#L140

@DeMoorJasper
Copy link
Member

DeMoorJasper commented Oct 6, 2018

@devongovett thought changing the environment variable could overwrite this, but looking at the cli code it does not. Should have probably double checked first.
Not sure if build and serve should behave differently in such a way, it's a bit confusing.

devongovett pushed a commit that referenced this pull request Oct 15, 2018
Was running `parcel build` and the auto installer started running, I went to disable it and found that the option was not available here
devongovett pushed a commit that referenced this pull request Oct 15, 2018
Was running `parcel build` and the auto installer started running, I went to disable it and found that the option was not available here
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants