Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoinstall): Add disabling of autoinstall globally via environm… #2152

Conversation

cacheflow
Copy link
Contributor

@cacheflow cacheflow commented Oct 16, 2018

↪️ Pull Request

-Allow disabling of autoinstall via a environment variable named PARCEL_AUTOINSTALL.

✔️ PR Todo

  • [x ] Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • [ x] Included links to related issues/PRs

Feature Request: #2081

@cacheflow cacheflow force-pushed the disable-autoinstall-globally-via-env-var branch from b3daf7f to 644170a Compare October 16, 2018 19:32
@cacheflow cacheflow force-pushed the disable-autoinstall-globally-via-env-var branch 2 times, most recently from caa6a36 to 10cfca9 Compare October 18, 2018 00:59
const autoInstall =
typeof options.autoinstall === 'boolean'
? options.autoinstall
: typeof process.env.PARCEL_AUTOINSTALL === 'boolean'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does that actually get converted to a boolean if you provide this environment variable from a terminal?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not, so I've updated the check.

@cacheflow cacheflow force-pushed the disable-autoinstall-globally-via-env-var branch 3 times, most recently from 856764c to 47b998f Compare October 30, 2018 00:16
devongovett and others added 3 commits December 18, 2018 09:39
 - @parcel/babel-register@1.11.0
 - @parcel/fs@1.11.0
 - @parcel/integration-tests@1.11.0
 - @parcel/logger@1.11.0
 - parcel-bundler@1.11.0
 - @parcel/test-utils@1.11.0
 - @parcel/utils@1.11.0
 - @parcel/watcher@1.11.0
 - @parcel/workers@1.11.0
@devongovett devongovett force-pushed the disable-autoinstall-globally-via-env-var branch from 47b998f to ddb8234 Compare March 6, 2019 04:56
@devongovett devongovett merged commit 011bfa9 into parcel-bundler:master Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants