From 2f83f6f7a82cbd51b983158a4ac3e58cbae286f2 Mon Sep 17 00:00:00 2001 From: Maxim Filimonov Date: Wed, 31 Oct 2018 21:46:35 +1000 Subject: [PATCH 1/2] add debugger flag for non production builds in Elm --- .../core/parcel-bundler/src/assets/ElmAsset.js | 1 + packages/core/parcel-bundler/test/elm.js | 17 +++++++++++++++++ 2 files changed, 18 insertions(+) diff --git a/packages/core/parcel-bundler/src/assets/ElmAsset.js b/packages/core/parcel-bundler/src/assets/ElmAsset.js index 9fc3a543a2f..1bfa210140a 100644 --- a/packages/core/parcel-bundler/src/assets/ElmAsset.js +++ b/packages/core/parcel-bundler/src/assets/ElmAsset.js @@ -40,6 +40,7 @@ class ElmAsset extends Asset { await this.getConfig(['elm.json'], {load: false}); } + options.debug = !this.options.production; if (this.options.minify) { options.optimize = true; } diff --git a/packages/core/parcel-bundler/test/elm.js b/packages/core/parcel-bundler/test/elm.js index 31174c29615..49d6e1f112f 100644 --- a/packages/core/parcel-bundler/test/elm.js +++ b/packages/core/parcel-bundler/test/elm.js @@ -14,6 +14,23 @@ describe('elm', function() { let output = await run(b); assert.equal(typeof output().Elm.Main.init, 'function'); }); + it('should produce a elm bundle with debugger', async function() { + let b = await bundle(__dirname + '/integration/elm/index.js'); + + const output = await run(b); + let js = await fs.readFile(__dirname + '/dist/index.js', 'utf8'); + assert(js.includes('elm$browser$Debugger')); + }); + + it('should remove debugger in production', async function() { + let b = await bundle(__dirname + '/integration/elm/index.js', { + production: true + }); + + const output = await run(b); + let js = await fs.readFile(__dirname + '/dist/index.js', 'utf8'); + assert(!js.includes('elm$browser$Debugger')); + }); it('should minify Elm in production mode', async function() { let b = await bundle(__dirname + '/integration/elm/index.js', { From 2e40867c8e9c9bbb69dc1e5f8db543a2fb457745 Mon Sep 17 00:00:00 2001 From: Maxim Filimonov Date: Thu, 1 Nov 2018 21:18:13 +1000 Subject: [PATCH 2/2] satisfy linter --- packages/core/parcel-bundler/test/elm.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/core/parcel-bundler/test/elm.js b/packages/core/parcel-bundler/test/elm.js index 49d6e1f112f..7a350ce9248 100644 --- a/packages/core/parcel-bundler/test/elm.js +++ b/packages/core/parcel-bundler/test/elm.js @@ -17,7 +17,7 @@ describe('elm', function() { it('should produce a elm bundle with debugger', async function() { let b = await bundle(__dirname + '/integration/elm/index.js'); - const output = await run(b); + await run(b); let js = await fs.readFile(__dirname + '/dist/index.js', 'utf8'); assert(js.includes('elm$browser$Debugger')); }); @@ -27,7 +27,7 @@ describe('elm', function() { production: true }); - const output = await run(b); + await run(b); let js = await fs.readFile(__dirname + '/dist/index.js', 'utf8'); assert(!js.includes('elm$browser$Debugger')); });