refactor: remove unnecessary not null check

[clarkdo]

↪️ Pull Request

Remove option not null check since it won't be null

💻 Examples

🚨 Test instructions

✨ PR Todo

• Added/updated unit tests for this change
• Filled out test instructions (In case there aren't any unit tests)
• Included links to related issues/PRs

[DeMoorJasper]

This function does not ensure it's not null.
But you're right that it should not be used if options is null.

In theory options could be null though, but the current implementation of the watcher has a default that parcel uses which makes it currently impossible to have options as null.
If this would change to allowing null, this thing would break down. (Also if these helperfunctions would ever be used outside of the watcher it would require this check)

I'm not sure if I should approve this PR or not, as it just removes a little safety from the functions and doesn't have any benefits afaik.

[clarkdo]

@DeMoorJasper Thank you for your reply 😄

In my perspective, if option can be null, then we should also check https://github.com/parcel-bundler/parcel/blob/master/packages/core/watcher/src/options.js#L34 since it will lead to exception, otherwise option not null checking can be removed.

But I can understand your suggestion. This is is not a critical issue or new feature, so you can feel free to close this ticket 😸

[DeMoorJasper]

@clarkdo When I was reviewing this, I actually also realised https://github.com/parcel-bundler/parcel/blob/master/packages/core/watcher/src/options.js#L34 should be inside the check as well. If you'd like to fix that that would be awesome, as that would actually prevent issues if we ever allow the watcher to have null as options.

[clarkdo]

@DeMoorJasper Updated