Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip external import's from processing #2380

Merged
merged 1 commit into from Dec 11, 2018
Merged

Conversation

DeMoorJasper
Copy link
Member

@DeMoorJasper DeMoorJasper commented Dec 9, 2018

↪️ Pull Request

Closes #2374 Fixes #2358

Future work: Rewrite url imports to use parcel's bundle loader for IE support.

💻 Examples

const lodash = import('https://cdnjs.cloudflare.com/ajax/libs/lodash.js/4.17.11/lodash.min.js');

lodash.then(() => console.log(_.VERSION));

🚨 Test instructions

Run the example or experiment a lil with this branch.

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@devongovett devongovett merged commit 7a540fc into master Dec 11, 2018
@devongovett devongovett deleted the fix-external-imports branch December 11, 2018 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't import absolute URLs, e.g. from CDN
2 participants