Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HMR with elm-hot #2388

Merged
merged 1 commit into from Dec 11, 2018
Merged

Conversation

ktosiek
Copy link
Contributor

@ktosiek ktosiek commented Dec 10, 2018

This is a copy of #2378, which is having some technical difficulties.

↪️ Pull Request

This PR adds integration with elm-hot - the HMR solution for Elm (at least I don't know about any other :-)). I've published this code before as a plugin, and after a suggestion from @domenkozar decided it would make more sense upstream.

💻 Examples

This will help when editing the app without changing the type of the app's model. Visual tweaks or testing the update logic should be much easier with working HMR.

🚨 Test instructions

Editing an Elm app (like changing a string) should cause the changes to be applied, without refreshing the page or changing the app's state.

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@ktosiek ktosiek mentioned this pull request Dec 10, 2018
3 tasks
@devongovett
Copy link
Member

Awesome, thank you! 🎉

@devongovett devongovett merged commit 697b234 into parcel-bundler:master Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants