Fix localRequire with package/path requests #2425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devongovett
requested changes
Dec 18, 2018
| } | ||
|
|
||
| return parts; | ||
| Resolver.getModuleParts = function(name) { |
There was a problem hiding this comment.
You could use the static keyword and leave this in the class. A better way might be to just extract this function as a util file, that way localRequire isn't dependent on the resolver. In v2, the resolver will be in a separate package.
There was a problem hiding this comment.
just extract this function as a util file
Done. How should this be tested? Determining a package which is definitely not already installed by some parcel package doesn't seem very reliable.
devongovett
approved these changes
Jan 16, 2019
wbinnssmith
pushed a commit
that referenced
this pull request
Mar 13, 2019
wbinnssmith
pushed a commit
that referenced
this pull request
Mar 14, 2019
wbinnssmith
pushed a commit
that referenced
this pull request
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Followup for #2415
💻 Examples
localRequire("cssnano/package.json") would try to install the package "cssnano/package.json"
🚨 Test instructions
✔️ PR Todo