Resolve package.browser in subfolders (with backslashes) #2445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmarshall
changed the title
danmarshall
changed the title
|
Aw shucks, it's mostly good: Not sure why it failed, other than this:
|
DeMoorJasper
previously approved these changes
Dec 23, 2018
devongovett
reviewed
Dec 24, 2018
|
@DeMoorJasper @devongovett thanks for the reviews. I added one more commit in hopes that it would trigger a new CI build. By adding a commit, GitHub states that I "dismissed" your review .🤔 |
|
Woohoo! it passed 🥇 |
DeMoorJasper
approved these changes
Dec 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Fixes #1883
A file path in a subfolder on Windows may contain backslashes, which will not match aliases in the browser field of package.json.