Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement depth option for detaild report #2466

Merged

Conversation

garthenweb
Copy link
Contributor

↪️ Pull Request

Allows define a depth for the detailedReport option. Implements #1857.

💻 Examples

Show all assets used within bundles:

new Bundler('./path/to/file.ts', { detailedReport: 'all' });

Show the largest 50 assets per bundle:

parcel build ./path/to/file.ts --detailed-report=50

🚨 Test instructions

With this changes, when the --detailed-report argument is used via cli without an option, it must be used after the path to the resource, because otherwise it would use the file name as its value.

Right: parcel build ./path/to/file.ts --detailed-report
Wrong: parcel build --detailed-report ./path/to/file.ts

Not sure if this is considered a breaking change for parcel, I did not found a good way to solve this using commander which is used for parsing the command on the shell.

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@garthenweb garthenweb force-pushed the feat/allow-detailt-report-depth branch from 720d7c3 to cfe442d Compare January 2, 2019 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants