Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and reenable windows scope-hoisting tests #2537

Merged
merged 1 commit into from Jan 15, 2019
Merged

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Jan 13, 2019

↪️ Pull Request

The scopehoisting test on Windows were disabled because the afterEach test hook deleting the dist folder failed with a permissions error.
This was because JSConcatPackager.end() didn't call super.end() to close the file handle (no issues on macOS / Linux).

I also wrapped the call to concat and everything thereafter in a try-catch, because let {code: output} = concat(this, ast); can throw because of e.g. a missing import, meaning super.end() would never be called.

💻 Examples

🚨 Test instructions

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@devongovett devongovett merged commit a4eb94e into master Jan 15, 2019
@devongovett devongovett deleted the win-scopehoisting branch January 15, 2019 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants