Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

use env port #2559

Merged
merged 2 commits into from Jan 21, 2019
Merged

use env port #2559

merged 2 commits into from Jan 21, 2019

Conversation

lizzzp1
Copy link

@lizzzp1 lizzzp1 commented Jan 20, 2019

#1126
Replaces command.port with process.env.PORT
Adds process.env.PORT as additional default

I think it's ok to just replace? 馃槄

馃捇 Examples

馃毃 Test instructions

鉁旓笍 PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

Don't think test are applicable here.

@mischnic
Copy link
Member

mischnic commented Jan 20, 2019

I think it's ok to just replace? 馃槄

I think it should rather be command.port || process.env.PORT ||聽1234, that way the cli flag will take precedence over the env variable (if used)

@lizzzp1
Copy link
Author

lizzzp1 commented Jan 20, 2019

@mischnic thank you for that feedback! -- Tests are failing. 馃 Could it be a yarn/node version issue?

@mischnic
Copy link
Member

Tests are failing. 馃 Could it be a yarn/node version issue?

These tests have been failing for a while, they are not related to your changes (I've tried to fix them in #2532 but Windows isn't working yet)

@devongovett devongovett merged commit bdc044a into parcel-bundler:master Jan 21, 2019
@devongovett
Copy link
Member

Thank you! 馃檹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants