Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty html files #2621

Merged
merged 1 commit into from Feb 7, 2019
Merged

Handle empty html files #2621

merged 1 commit into from Feb 7, 2019

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Feb 6, 2019

↪️ Pull Request

Admittedly a niche case, but it should not throw an error:

index.html: Cannot read property 'walk' of null
    parcel-bundler/src/assets/HTMLAsset.js

(I only indented the walk call, git's diffing algorithm makes it seem like more changed)

Proper fix for #2397

💻 Examples

Processing an empty html file in dev mode.

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@DeMoorJasper DeMoorJasper merged commit bdef68b into master Feb 7, 2019
@DeMoorJasper DeMoorJasper deleted the empty-html branch February 7, 2019 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants