Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow dotfiles to be served #2641

Merged
merged 1 commit into from Feb 17, 2019
Merged

Allow dotfiles to be served #2641

merged 1 commit into from Feb 17, 2019

Conversation

mischnic
Copy link
Member

↪️ Pull Request

Requesting output files starting with a dot would result in them being handled as missing.

As documented: https://github.com/expressjs/serve-static#dotfiles

Closes #2628

💻 Examples

dist
 |- .mybundle.213fasd.js
 |- index.html (includes .mybundle.213fasd.js)

🚨 Test instructions

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@devongovett devongovett merged commit d86e4fd into master Feb 17, 2019
@devongovett devongovett deleted the server-dotfiles branch February 17, 2019 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeMoorJasper DeMoorJasper DeMoorJasper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot serve entry file from a dot folder
3 participants
@mischnic @DeMoorJasper @devongovett