Prevent circular deps from causing a stack overflow in HMR runtime

[rhurstdialpad]

↪️ Pull Request

This PR prevents a stack overflow when updating files that have circular dependencies. This issue occurs when HMR tries to reload dependencies and gets stuck following the loop. The fix is achieved by adding a set that contains each of the asset ID updated in the same HMR update event. This set is used to keep track of what has been updated and skips loading the same asset more than once.

Fixes #1192

[RobertWHurst]

@DeMoorJasper @devongovett This is a pretty small fix. What do you guys think?

[DeMoorJasper]

Some kind of test would be good although at first sight the code looks good.
I also worry about using Set as it's not fully supported on IE (although this PR doesn't rely on behaviour that would break in IE afaik, not sure if we should use it)

[ksafranski]

Confirmed this fixes an issue my team is having with maximum call stack errors on hmr reload. Tested on multiple browsers. Any word on how soon this might merge?

[DeMoorJasper]

A test would def help in getting this merged, merging and updates are slow atm due to our attention being divided between updating Parcel 1 and building parcel 2

_{Sent with GitHawk}

[mischnic]

I have added a test and pushed to your branch, @rhurstdialpad I hope you don't mind.

[rhurstdialpad]

@mischnic No problem at all. Thanks for adding the test. Stoked that has landed. 🍻

[JasCodes]

Any timeframes on next release?

[aMarCruz]

About to go back to webpack but I found this commit and now parcel w/ typescript works like a charm. Thanks @rhurstdialpad !!!

[RobertWHurst]

@aMarCruz Not a problem, happy to help. I love Parcel.

[frother]

@aMarCruz How did you go about applying this patch? There doesn't seem to be a new version released. Thanks @RobertWHurst for the fix!!!

[aMarCruz]

@frother ,
Clone the repo and generate the package:

git clone https://github.com/parcel-bundler/parcel.git
cd parcel/packages/core/parcel-bundler
yarn && yarn build
npm pack

Move the generated "parcel-bundler-1.11.0.tgz" file to some folder in your app root and install it from there (for example, in a folder <app-root>.local-pkgs/):

// point the package.json dependency to the local package:

devDependencies: {
  "parcel-bundler": "./.local-pkgs/parcel-bundler-1.11.0.tgz",
}

then...

yarn

Done.

I hope I have not forgotten something.

BTW: "merging and updates are slow atm due to our attention being divided between updating Parcel 1 and building parcel 2" ...this words remind me of Windows, when the urgency of launching new features was more important than solving the bugs.

[JasCodes]

@aMarCruz I actually build it for myself, but custom fonts were not working. You getting same kinna bug?

[aMarCruz]

@Jas99 , I don't use custom fonts.

[frother]

@aMarCruz Many thanks.