Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundler Rewrite: Experimental Bundler #6975

Merged
merged 93 commits into from Dec 16, 2021
Merged

Bundler Rewrite: Experimental Bundler #6975

merged 93 commits into from Dec 16, 2021

Conversation

gorakong
Copy link
Member

@gorakong gorakong commented Sep 22, 2021

↪️ Pull Request

This is a draft PR for the bundler rewrite as per the prototype in https://github.com/devongovett/bundler-algorithm/blob/master/src/main.rs . Changes are mostly in ExperimentalBundler.js. The prototype generates what we call an “Ideal Bundle Graph” that is maximally deduplicated. We replicated this "ideal graph", and then backported it to our previous bundle graph structure.

Things to note:

  • Within the context of the ideal graph, bundle groups are simply groupings of bundles and not any physical nodes.
  • BundleRoots represent a bundle's entry asset (not to be confused with a project's entry). Not all assets are bundleRoots.
  • We have many auxiliary data structures that we’re hoping to phase out once we pass all integration tests.

🚨 Test instructions

To run tests using the Experimental Bundler, use the flag PARCEL_TEST_EXPERIMENTAL_BUNDLER=1.

@gorakong gorakong marked this pull request as ready for review December 14, 2021 17:58
@devongovett devongovett merged commit 84847ed into v2 Dec 16, 2021
@devongovett devongovett deleted the bundler-rewrite branch December 16, 2021 02:13
bhovhannes pushed a commit to bhovhannes/parcel that referenced this pull request Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants