Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use our own fs instead of Node's fs in the Npm package installer #7103

Merged
merged 1 commit into from Oct 16, 2021
Merged

Conversation

mischnic
Copy link
Member

Probably one case of Callback must be a function?

@height
Copy link

height bot commented Oct 15, 2021

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 2.26s +19.00ms
Cached 316.00ms -11.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/index.c1bc86aa.css 94.00b +0.00b 1.33s -71.00ms 🚀
dist/modern/index.57a95cbe.css 94.00b +0.00b 1.33s -70.00ms 🚀

React HackerNews ✅

Timings

Description Time Difference
Cold 11.37s -192.00ms
Cached 530.00ms +23.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.23m -768.00ms
Cached 1.82s +23.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Three.js ✅

Timings

Description Time Difference
Cold 7.73s -37.00ms
Cached 423.00ms -18.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants