Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump swc, use strip_with_jsx #7114

Merged
merged 4 commits into from Oct 21, 2021
Merged

Bump swc, use strip_with_jsx #7114

merged 4 commits into from Oct 21, 2021

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Oct 17, 2021

Use typescript::strip_with_jsx instead of the fix from #7057 (swc-project/swc#2418)

Order of transforms taken from https://github.com/swc-project/swc/blob/63ad4b432272718f52e515b5f9c69c6f85175389/src/config/mod.rs#L282-L319:

  1. decorators
  2. typescript
  3. global_mark
  4. react

Closes #7142
Closes #7083

@height
Copy link

height bot commented Oct 17, 2021

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

parcel-benchmark commented Oct 17, 2021

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 2.55s +145.00ms ⚠️
Cached 353.00ms +42.00ms ⚠️

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 1.02s +933.00ms ⚠️
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 1.02s +933.00ms ⚠️
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 1.02s +933.00ms ⚠️
dist/legacy/index.96016b08.js 1.59kb +0.00b 1.11s +94.00ms ⚠️
dist/legacy/index.8aaa89c9.js 1.20kb +0.00b 1.11s +94.00ms ⚠️
dist/modern/index.6be20f01.js 1.13kb +0.00b 1.11s +94.00ms ⚠️
dist/legacy/index.html 826.00b +0.00b 1.31s +108.00ms ⚠️
dist/modern/index.html 749.00b +0.00b 1.31s +108.00ms ⚠️
dist/legacy/index.c1bc86aa.css 94.00b +0.00b 1.46s +140.00ms ⚠️
dist/modern/index.57a95cbe.css 94.00b +0.00b 1.46s +139.00ms ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 766.00ms +673.00ms ⚠️
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 767.00ms +673.00ms ⚠️
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 766.00ms +673.00ms ⚠️

React HackerNews ✅

Timings

Description Time Difference
Cold 11.68s -466.00ms
Cached 490.00ms -37.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.28m +261.00ms
Cached 1.96s +72.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/index.9b254630.js 1.78mb -15.00b 🚀 22.02s +80.00ms
dist/editorView.098fecd9.js 594.84kb -9.00b 🚀 57.94s +261.00ms

Cached Bundles

Bundle Size Difference Time Difference
dist/index.747a1ecf.js 1.78mb -15.00b 🚀 22.80s +298.00ms
dist/editorView.bf9ed67d.js 594.84kb -9.00b 🚀 59.88s -174.00ms

Three.js ✅

Timings

Description Time Difference
Cold 8.26s -363.00ms
Cached 463.00ms +1.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants