Update package.json to include the repository #7184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi there! This change adds the repository property to your package.json file(s). Having this available provides a number of benefits to security tooling. For example, it allows for greater trust by checking for signed commits, contributors to a release and validating history with the project. It also allows for comparison between the source code and the published artifact in order to detect attacks on authors during the publication process. We validate that we're making a PR against the correct repository by comparing the metadata for the published artifact on [npmjs.com](www.npmjs.com) against the metadata in the package.json file in the repository. This change is provided by a team at Microsoft -- we're happy to answer any questions you may have. (Members of this team include [@s-tuli](https://github.com/s-tuli), [@iarna](https://github.com/iarna), [@rancyr](https://github.com/v-rr), [@jaydon Peng](https://github.com/v-jiepeng), [@zhongpeng Zhou](https://github.com/v-zhzhou) and [@jingying Gu](https://github.com/v-gjy)). If you would prefer that we not make these sorts of PRs to projects you maintain, please just say. If you'd like to learn more about what we're doing here, we've prepared a document talking about both this project and some of our other activities around supply chain security here: [microsoft/Secure-Supply-Chain](https://github.com/microsoft/Secure-Supply-Chain) This PR provides repository metadata for the following packages: * @parcel/babel-preset * @parcel/babylon-walk * @parcel/create-react-app * @parcel/fs-write-stream-atomic
|
|
Seems fine to me. Why did you only add it to these packages? Should we add it to all of them? |
|
I believe that the other packages already have repository keys, it was just these that we found missing. Did we miss some ourselves? |
|
Ah, I just assumed they weren't there. Looks like they are. Would be nice to add the "directory" key though. Can do that separately. Thanks! |
lettertwo
added a commit
that referenced
this pull request
Nov 15, 2021
* v2: (68 commits) Fix RangeError in `not export` error with other file type (#7295) Apply sourcemap in @parcel/transformer-typescript-tsc (#7287) Fix side effects glob matching (#7288) Fix changelog headings v2.0.1 Changelog for v2.0.1 Resolve GLSL relative to the importer, not the asset (#7263) fix: add @parcel/diagnostic as dependency of @parcel/transformer-typescript-types (#7248) Fixed missing "Parcel" export member in Module "@parcel/core" (#7250) Add script to sync engines with core version (#7207) Bump swc (#7216) Make Webpack loader detection regex dramatically faster (#7226) swc optimizer (#7212) Update esbuild in optimizer (#7233) Properly visit member expressions (#7228) Update to prettier 2 (#7209) Fix serve mode with target override and target source fields (#7187) Update package.json to include the repository (#7184) fix #6730: add transformer-raw as dependency of config-webextension (#7193) Log warning instead of crash if image optimizer fails (#7119) ...
lettertwo
added a commit
that referenced
this pull request
Nov 15, 2021
* v2: (68 commits) Fix RangeError in `not export` error with other file type (#7295) Apply sourcemap in @parcel/transformer-typescript-tsc (#7287) Fix side effects glob matching (#7288) Fix changelog headings v2.0.1 Changelog for v2.0.1 Resolve GLSL relative to the importer, not the asset (#7263) fix: add @parcel/diagnostic as dependency of @parcel/transformer-typescript-types (#7248) Fixed missing "Parcel" export member in Module "@parcel/core" (#7250) Add script to sync engines with core version (#7207) Bump swc (#7216) Make Webpack loader detection regex dramatically faster (#7226) swc optimizer (#7212) Update esbuild in optimizer (#7233) Properly visit member expressions (#7228) Update to prettier 2 (#7209) Fix serve mode with target override and target source fields (#7187) Update package.json to include the repository (#7184) fix #6730: add transformer-raw as dependency of config-webextension (#7193) Log warning instead of crash if image optimizer fails (#7119) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
This change adds the repository property to your package.json file(s). Having this available provides a number of benefits to security tooling. For example, it allows for greater trust by checking for signed commits, contributors to a release and validating history with the project. It also allows for comparison between the source code and the published artifact in order to detect attacks on authors during the publication process.
We validate that we're making a PR against the correct repository by comparing the metadata for the published artifact on npmjs.com against the metadata in the package.json file in the repository.
This change is provided by a team at Microsoft -- we're happy to answer any questions you may have. (Members of this team include @s-tuli, @iarna, @rancyr, @Jaydon Peng, @Zhongpeng Zhou and @Jingying Gu). If you would prefer that we not make these sorts of PRs to projects you maintain, please just say. If you'd like to learn more about what we're doing here, we've prepared a document talking about both this project and some of our other activities around supply chain security here: microsoft/Secure-Supply-Chain
This PR provides repository metadata for the following packages: