Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream some changes from the REPL #7208

Merged
merged 11 commits into from Dec 8, 2021
Merged

Upstream some changes from the REPL #7208

merged 11 commits into from Dec 8, 2021

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Oct 28, 2021

  • IDBCache class (at least for now with idb as a devdependency so it's not installed for everyone)
  • use msgpack in browsers
  • various "browser": { "..": false } statements for code that needs native packages
  • don't throw if SharedArrayBuffer is undefined

@height
Copy link

height bot commented Oct 28, 2021

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@mischnic mischnic mentioned this pull request Oct 28, 2021
@parcel-benchmark
Copy link

parcel-benchmark commented Oct 28, 2021

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 2.39s -43.00ms
Cached 410.00ms +20.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 683.00ms +574.00ms ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 702.00ms +585.00ms ⚠️
dist/legacy/index.html 826.00b +0.00b 1.19s -61.00ms 🚀
dist/modern/index.html 749.00b +0.00b 1.19s -61.00ms 🚀
dist/legacy/index.c1bc86aa.css 94.00b +0.00b 1.35s -79.00ms 🚀
dist/modern/index.57a95cbe.css 94.00b +0.00b 1.35s -80.00ms 🚀

React HackerNews ✅

Timings

Description Time Difference
Cold 11.84s +57.00ms
Cached 523.00ms +8.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/logo.c5bb83f1.png 246.00b +0.00b 5.44s -840.00ms 🚀

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.30m +476.00ms
Cached 1.73s +102.00ms ⚠️

Cold Bundles

Bundle Size Difference Time Difference
dist/editorView.af442747.js 594.92kb +0.00b 58.79s +15.66s ⚠️
dist/popup.64bc9a82.js 209.67kb +0.00b 58.79s +15.64s ⚠️
dist/EmojiPickerComponent.922af3e4.js 147.13kb +0.00b 23.70s -12.43s 🚀
dist/Toolbar.1af0e801.js 107.23kb +0.00b 58.79s +15.66s ⚠️
dist/Modal.cd71eaf3.js 45.33kb +0.00b 58.79s +15.64s ⚠️
dist/esm.f1a592e5.js 33.15kb +0.00b 23.70s -12.43s 🚀
dist/DatePicker.f2994e45.js 22.98kb +0.00b 23.70s -12.43s 🚀
dist/js.660b75db.js 17.25kb +0.00b 43.26s -15.13s 🚀
dist/ui.5d3f7adc.js 14.94kb +0.00b 58.80s +15.64s ⚠️
dist/smartMediaEditor.48c8cf63.js 13.25kb +0.00b 58.79s +15.66s ⚠️
dist/dropzone.39132d0c.js 12.16kb +0.00b 58.79s +15.64s ⚠️
dist/EmojiPickerComponent.0482d6c0.js 3.73kb +0.00b 58.80s +15.64s ⚠️
dist/png-chunks-extract.5c9c0fb9.js 3.58kb +0.00b 43.26s -15.13s 🚀
dist/dropzone.55bef257.js 3.29kb +0.00b 58.79s +15.64s ⚠️
dist/clipboard.df70240c.js 2.93kb +0.00b 58.79s +15.66s ⚠️
dist/ResourcedEmojiComponent.667554b4.js 2.12kb +0.00b 58.80s +15.64s ⚠️
dist/feedback.c7e69064.js 1.77kb +0.00b 23.70s -12.43s 🚀
dist/browser.4e039ed7.js 1.69kb +0.00b 58.79s +15.66s ⚠️
dist/workerHasher.3639b1f9.js 1.63kb +0.00b 23.70s -12.43s 🚀
dist/heading6.a693146e.js 1.51kb +0.00b 23.69s -12.44s 🚀
dist/heading5.8bfafe21.js 1.38kb +0.00b 23.69s -12.44s 🚀
dist/expand.a44d10fe.js 1.29kb +0.00b 23.70s -12.43s 🚀
dist/media-card-analytics-error-boundary.c718a9a7.js 1.12kb +0.00b 58.79s +15.64s ⚠️
dist/media-picker-analytics-error-boundary.8b2547e5.js 966.00b +0.00b 58.79s +15.64s ⚠️
dist/simpleHasher.fc0d6100.js 643.00b +0.00b 58.80s +15.64s ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/editorView.af442747.js 594.92kb +0.00b 43.35s -15.02s 🚀
dist/popup.64bc9a82.js 209.67kb +0.00b 43.36s -15.01s 🚀
dist/EmojiPickerComponent.922af3e4.js 147.13kb +0.00b 36.10s +12.35s ⚠️
dist/Toolbar.1af0e801.js 107.23kb +0.00b 43.36s -15.02s 🚀
dist/Modal.cd71eaf3.js 45.33kb +0.00b 43.36s -15.01s 🚀
dist/esm.f1a592e5.js 33.15kb +0.00b 36.10s +12.35s ⚠️
dist/DatePicker.f2994e45.js 22.98kb +0.00b 36.10s +12.35s ⚠️
dist/js.660b75db.js 17.25kb +0.00b 57.90s +14.88s ⚠️
dist/ui.5d3f7adc.js 14.94kb +0.00b 43.36s -15.01s 🚀
dist/smartMediaEditor.48c8cf63.js 13.25kb +0.00b 43.35s -15.02s 🚀
dist/dropzone.39132d0c.js 12.16kb +0.00b 43.36s -15.01s 🚀
dist/EmojiPickerComponent.0482d6c0.js 3.73kb +0.00b 43.36s -15.01s 🚀
dist/png-chunks-extract.5c9c0fb9.js 3.58kb +0.00b 57.90s +14.88s ⚠️
dist/dropzone.55bef257.js 3.29kb +0.00b 43.36s -15.01s 🚀
dist/clipboard.df70240c.js 2.93kb +0.00b 43.36s -15.01s 🚀
dist/ResourcedEmojiComponent.667554b4.js 2.12kb +0.00b 43.36s -15.01s 🚀
dist/feedback.c7e69064.js 1.77kb +0.00b 36.10s +12.35s ⚠️
dist/browser.4e039ed7.js 1.69kb +0.00b 43.36s -15.01s 🚀
dist/workerHasher.3639b1f9.js 1.63kb +0.00b 36.10s +12.35s ⚠️
dist/heading6.a693146e.js 1.51kb +0.00b 36.10s +12.36s ⚠️
dist/heading5.8bfafe21.js 1.38kb +0.00b 36.10s +12.36s ⚠️
dist/expand.a44d10fe.js 1.29kb +0.00b 36.10s +12.35s ⚠️
dist/media-card-analytics-error-boundary.c718a9a7.js 1.12kb +0.00b 43.36s -15.01s 🚀
dist/media-picker-analytics-error-boundary.8b2547e5.js 966.00b +0.00b 43.36s -15.01s 🚀
dist/simpleHasher.fc0d6100.js 643.00b +0.00b 43.36s -15.01s 🚀

Three.js ✅

Timings

Description Time Difference
Cold 8.05s -32.00ms
Cached 439.00ms -6.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@mischnic mischnic merged commit 4f0d297 into v2 Dec 8, 2021
@mischnic mischnic deleted the repl-upstream branch December 8, 2021 08:58
bhovhannes pushed a commit to bhovhannes/parcel that referenced this pull request Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants