Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly pad numbers in parcel-hash browser polyfill #7415

Merged
merged 2 commits into from Dec 8, 2021

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Dec 7, 2021

To behave like

let res_str = format!("{:016x}", res);

@height
Copy link

height bot commented Dec 7, 2021

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

parcel-benchmark commented Dec 7, 2021

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.80s +18.00ms
Cached 298.00ms -14.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 87.00ms -436.00ms 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 521.00ms +285.00ms ⚠️
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 522.00ms +285.00ms ⚠️
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 521.00ms +285.00ms ⚠️

React HackerNews ✅

Timings

Description Time Difference
Cold 8.91s -64.00ms
Cached 406.00ms -7.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/logo.c5bb83f1.png 246.00b +0.00b 4.14s -570.00ms 🚀

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 57.60s +150.00ms
Cached 1.36s +47.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/editorView.af442747.js 594.92kb +0.00b 43.77s +11.65s ⚠️
dist/popup.64bc9a82.js 209.67kb +0.00b 43.77s +11.65s ⚠️
dist/EmojiPickerComponent.922af3e4.js 147.13kb +0.00b 17.70s -9.34s 🚀
dist/Toolbar.1af0e801.js 107.23kb +0.00b 43.77s +11.65s ⚠️
dist/Modal.cd71eaf3.js 45.33kb +0.00b 43.77s +11.65s ⚠️
dist/esm.f1a592e5.js 33.15kb +0.00b 17.70s -9.34s 🚀
dist/DatePicker.f2994e45.js 22.98kb +0.00b 17.70s -9.34s 🚀
dist/js.660b75db.js 17.25kb +0.00b 32.66s -10.85s 🚀
dist/ui.5d3f7adc.js 14.94kb +0.00b 43.77s +11.65s ⚠️
dist/smartMediaEditor.48c8cf63.js 13.25kb +0.00b 43.77s +11.65s ⚠️
dist/dropzone.39132d0c.js 12.16kb +0.00b 43.77s +11.65s ⚠️
dist/EmojiPickerComponent.0482d6c0.js 3.73kb +0.00b 43.77s +11.65s ⚠️
dist/png-chunks-extract.5c9c0fb9.js 3.58kb +0.00b 32.66s -10.85s 🚀
dist/dropzone.55bef257.js 3.29kb +0.00b 43.77s +11.65s ⚠️
dist/clipboard.df70240c.js 2.93kb +0.00b 43.77s +11.65s ⚠️
dist/ResourcedEmojiComponent.667554b4.js 2.12kb +0.00b 43.77s +11.65s ⚠️
dist/feedback.c7e69064.js 1.77kb +0.00b 17.70s -9.34s 🚀
dist/browser.4e039ed7.js 1.69kb +0.00b 43.77s +11.65s ⚠️
dist/workerHasher.3639b1f9.js 1.63kb +0.00b 17.70s -9.34s 🚀
dist/heading6.a693146e.js 1.51kb +0.00b 17.70s -9.34s 🚀
dist/heading5.8bfafe21.js 1.38kb +0.00b 17.70s -9.34s 🚀
dist/expand.a44d10fe.js 1.29kb +0.00b 17.70s -9.34s 🚀
dist/media-card-analytics-error-boundary.c718a9a7.js 1.12kb +0.00b 43.77s +11.65s ⚠️
dist/media-picker-analytics-error-boundary.8b2547e5.js 966.00b +0.00b 43.77s +11.65s ⚠️
dist/simpleHasher.fc0d6100.js 643.00b +0.00b 43.77s +11.65s ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/editorView.124f5fc0.js 594.92kb +0.00b 43.74s +11.45s ⚠️
dist/popup.64bc9a82.js 209.67kb +0.00b 43.74s +11.45s ⚠️
dist/EmojiPickerComponent.922af3e4.js 147.13kb +0.00b 17.62s -9.49s 🚀
dist/Toolbar.1af0e801.js 107.23kb +0.00b 43.74s +11.45s ⚠️
dist/Modal.cd71eaf3.js 45.33kb +0.00b 43.74s +11.45s ⚠️
dist/esm.f1a592e5.js 33.15kb +0.00b 17.63s -9.49s 🚀
dist/DatePicker.f2994e45.js 22.98kb +0.00b 17.62s -9.50s 🚀
dist/js.660b75db.js 17.25kb +0.00b 32.23s -11.63s 🚀
dist/ui.5d3f7adc.js 14.94kb +0.00b 43.74s +11.45s ⚠️
dist/smartMediaEditor.48c8cf63.js 13.25kb +0.00b 43.74s +11.45s ⚠️
dist/dropzone.39132d0c.js 12.16kb +0.00b 43.74s +11.45s ⚠️
dist/EmojiPickerComponent.0482d6c0.js 3.73kb +0.00b 43.74s +11.45s ⚠️
dist/png-chunks-extract.5c9c0fb9.js 3.58kb +0.00b 32.23s -11.63s 🚀
dist/dropzone.55bef257.js 3.29kb +0.00b 43.74s +11.45s ⚠️
dist/clipboard.df70240c.js 2.93kb +0.00b 43.74s +11.45s ⚠️
dist/ResourcedEmojiComponent.667554b4.js 2.12kb +0.00b 43.74s +11.45s ⚠️
dist/feedback.c7e69064.js 1.77kb +0.00b 17.62s -9.50s 🚀
dist/browser.4e039ed7.js 1.69kb +0.00b 43.74s +11.45s ⚠️
dist/workerHasher.3639b1f9.js 1.63kb +0.00b 17.63s -9.49s 🚀
dist/heading6.a693146e.js 1.51kb +0.00b 17.61s -9.51s 🚀
dist/heading5.8bfafe21.js 1.38kb +0.00b 17.61s -9.51s 🚀
dist/expand.a44d10fe.js 1.29kb +0.00b 17.62s -9.50s 🚀
dist/media-card-analytics-error-boundary.c718a9a7.js 1.12kb +0.00b 43.74s +11.45s ⚠️
dist/media-picker-analytics-error-boundary.8b2547e5.js 966.00b +0.00b 43.74s +11.45s ⚠️
dist/simpleHasher.fc0d6100.js 643.00b +0.00b 43.74s +11.45s ⚠️

Three.js ✅

Timings

Description Time Difference
Cold 6.17s +24.00ms
Cached 341.00ms +3.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@devongovett devongovett merged commit 1e40346 into v2 Dec 8, 2021
@devongovett devongovett deleted the xxhash-browser-pad branch December 8, 2021 03:06
bhovhannes pushed a commit to bhovhannes/parcel that referenced this pull request Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants