Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run Gzip and Brotli compressors in development #7510

Merged
merged 5 commits into from Jan 1, 2022
Merged

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Jan 1, 2022

Allow returning null or undefined from compressors to skip that plugin based on some condition at runtime, and use that to only run the gzip and brotli compressors in production. This is technically a breaking change but I can't image you would want the old behaviour

Other small fixes:

@height
Copy link

height bot commented Jan 1, 2022

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

parcel-benchmark commented Jan 1, 2022

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 2.35s -200.00ms 🚀
Cached 365.00ms +8.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 700.00ms +79.00ms ⚠️
dist/legacy/index.c1bc86aa.css 94.00b +0.00b 1.34s -214.00ms 🚀
dist/modern/index.57a95cbe.css 94.00b +0.00b 1.34s -214.00ms 🚀

Cached Bundles

No bundle changes detected.

React HackerNews ✅

Timings

Description Time Difference
Cold 11.11s +29.00ms
Cached 466.00ms -8.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/logo.c5bb83f1.png 246.00b +0.00b 4.99s -956.00ms 🚀

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.20m +618.00ms
Cached 1.54s -14.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/editorView.124f5fc0.js 594.92kb +0.00b 54.91s +14.10s ⚠️
dist/popup.64bc9a82.js 209.67kb +0.00b 54.91s +14.10s ⚠️
dist/Toolbar.1af0e801.js 107.23kb +0.00b 54.91s +14.10s ⚠️
dist/Modal.cd71eaf3.js 45.33kb +0.00b 54.91s +14.09s ⚠️
dist/ui.5d3f7adc.js 14.94kb +0.00b 54.91s +14.09s ⚠️
dist/smartMediaEditor.48c8cf63.js 13.25kb +0.00b 54.91s +14.10s ⚠️
dist/dropzone.39132d0c.js 12.16kb +0.00b 54.91s +14.10s ⚠️
dist/EmojiPickerComponent.0482d6c0.js 3.73kb +0.00b 54.91s +14.09s ⚠️
dist/dropzone.55bef257.js 3.29kb +0.00b 54.91s +14.10s ⚠️
dist/clipboard.df70240c.js 2.93kb +0.00b 54.91s +14.10s ⚠️
dist/ResourcedEmojiComponent.667554b4.js 2.12kb +0.00b 54.91s +14.09s ⚠️
dist/browser.4e039ed7.js 1.69kb +0.00b 54.91s +14.10s ⚠️
dist/media-card-analytics-error-boundary.c718a9a7.js 1.12kb +0.00b 54.91s +14.10s ⚠️
dist/media-picker-analytics-error-boundary.8b2547e5.js 966.00b +0.00b 54.91s +14.10s ⚠️
dist/simpleHasher.fc0d6100.js 643.00b +0.00b 54.91s +14.09s ⚠️

Three.js ✅

Timings

Description Time Difference
Cold 7.57s -183.00ms
Cached 395.00ms -15.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@devongovett
Copy link
Member

Looks like some failing tests?

@devongovett
Copy link
Member

Unit tests are still failing on Windows. Maybe something to do with the markdown escaping?

@devongovett devongovett merged commit 5d7af89 into v2 Jan 1, 2022
@devongovett devongovett deleted the compressor-skip branch January 1, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants