Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin lmdb@2.2.3 #7763

Merged
merged 2 commits into from Mar 1, 2022
Merged

Pin lmdb@2.2.3 #7763

merged 2 commits into from Mar 1, 2022

Conversation

lettertwo
Copy link
Member

Also bump msgpackr@^1.5.4 to avoid the duplicate dependency.

Short synopsis (See this comment for a more authoritative story):

  • At lmdb@2.2.0, an optimization for committing transactions was enabled by default. It performs asynchronous flushes of transacted data to disk, and then notifies when the flush has completed.
  • In Parcel's default multithreaded mode, a race condition occurs when threads would commit lmdb transactions and then terminate, thinking the transaction complete, while the flush to disk was still pending. When the flush completed, the attempt to notify the thread would segfault.
  • At lmdb@2.2.2, this optimization was again disabled by default

This PR pins the version of lmdb to avoid the possibility of installing a version that might trigger the race.

We will be trading the ability for lmdb to ship fixes for Parcel users without a new Parcel release, but many projects will have a lockfile that effectively prevents upgrading lmdb without a bump from Parcel, anyway.

Related:

Also bump msgpackr@^1.5.4 to avoid the duplicate dependency
@height
Copy link

height bot commented Feb 25, 2022

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

parcel-benchmark commented Feb 26, 2022

Benchmark Results

Kitchen Sink 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

React HackerNews ✅

Timings

Description Time Difference
Cold 10.73s -169.00ms
Cached 501.00ms +12.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/logo.c5bb83f1.png 246.00b +0.00b 5.61s +838.00ms ⚠️

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.18m -244.00ms
Cached 1.52s -3.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/editorView.15bc27a4.js 594.92kb +0.00b 39.68s -12.70s 🚀
dist/popup.f944d52c.js 209.67kb +0.00b 39.68s -12.71s 🚀
dist/Toolbar.b2284ccb.js 107.23kb +0.00b 39.68s -12.70s 🚀
dist/Modal.ec0ec3f8.js 45.33kb +0.00b 39.68s -12.71s 🚀
dist/ui.39c61c40.js 14.94kb +0.00b 39.68s -12.71s 🚀
dist/smartMediaEditor.27b49d9d.js 13.25kb +0.00b 39.68s -12.70s 🚀
dist/dropzone.0d17e26c.js 12.16kb +0.00b 39.68s -12.71s 🚀
dist/EmojiPickerComponent.8fb3dd15.js 3.73kb +0.00b 39.68s -12.70s 🚀
dist/dropzone.d03df26a.js 3.29kb +0.00b 39.68s -12.71s 🚀
dist/clipboard.7ceac12b.js 2.93kb +0.00b 39.68s -12.71s 🚀
dist/ResourcedEmojiComponent.9106318a.js 2.12kb +0.00b 39.68s -12.70s 🚀
dist/browser.d28fd36c.js 1.69kb +0.00b 39.68s -12.71s 🚀
dist/media-card-analytics-error-boundary.bead5bf1.js 1.12kb +0.00b 39.68s -12.71s 🚀
dist/media-picker-analytics-error-boundary.3df18700.js 966.00b +0.00b 39.68s -12.71s 🚀
dist/simpleHasher.a4c0be3d.js 643.00b +0.00b 39.68s -12.70s 🚀

Cached Bundles

No bundle changes detected.

Three.js ✅

Timings

Description Time Difference
Cold 8.08s +108.00ms
Cached 341.00ms +5.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/Three.js 579.68kb +0.00b 6.11s +396.00ms ⚠️

Click here to view a detailed benchmark overview.

@devongovett devongovett merged commit c670715 into v2 Mar 1, 2022
@devongovett devongovett deleted the lettertwo/lmdb-lock branch March 1, 2022 16:21
gorakong pushed a commit that referenced this pull request Nov 3, 2022
* upstream/v2: (26 commits)
  Replace typeof before DCE (#7788)
  Bump lmdb (#7797)
  Upgrade flow to 0.173.0 (#7809)
  Prevent `term-size` from being bundled (#7750)
  Pin lmdb@2.2.3 (#7763)
  Fix Windows CI (#7774)
  Upgrade Flow to 0.171.0 (#7667)
  Move tests to GitHub actions (#7678)
  v2.3.2
  Fix autoinstalling node builtins (#7735)
  Fix lint
  Use pinned versions
  Don't build native packages again during publish step
  Fix build
  Fix autoinstall
  v2.3.1
  Add diagnostic for failed autoinstall of node polyfill (#7682)
  v2.3.0
  Changelog for 2.3.0
  Support React 18 prereleases and experimental versions with automatic JSX runtime (#7642)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants