Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve emoji support detection #7775

Merged
merged 3 commits into from Mar 11, 2022
Merged

Improve emoji support detection #7775

merged 3 commits into from Mar 11, 2022

Conversation

kidonng
Copy link
Contributor

@kidonng kidonng commented Feb 28, 2022

↪️ Pull Request

Resolve #7767

Unfortunately is-unicode-supported has to be vendored since it's ESM-only.

💻 Examples

🚨 Test instructions

Assuming you are not on Windows (ironically, but this is easier to test):

# 1. Inspect $TERM
$ echo $TERM
xterm-256color
# 2. Create a dummy
$ touch index.html
# 3. Build the dummy, you should be able to see an emoji
$ yarn parcel build index.html
✨ Built in 511ms
# 4. Pretend to be Linux console and build the dummy again, should be able to see the fallback symbols:
$ TERM=linux yarn parcel build index.html
√ Built in 511ms

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@height
Copy link

height bot commented Feb 28, 2022

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@AGawrys
Copy link
Contributor

AGawrys commented Feb 28, 2022

Feel free to add me as a reviewer once you're satisfied with the PR TODO you listed :)

@kidonng
Copy link
Contributor Author

kidonng commented Feb 28, 2022

@AGawrys I don't think I have the permission to do that, but I have tested it locally and provided the test instructions.

@devongovett devongovett merged commit 8442c62 into parcel-bundler:v2 Mar 11, 2022
gorakong pushed a commit that referenced this pull request Nov 3, 2022
* upstream/v2:
  Upgrade Flow to 0.174.1 (#7849)
  v2.4.0
  v2.4.0 changelog
  Bump Parcel CSS
  Dynamic imports priority fix closes #6980 (#7061)
  fix(transformers): errors.map is not a function (#7672)
  Make NodeResolver check realpath before resolving with `source` entry (#7846)
  docs: fix wrong location documents (#7689)
  Fix: escape double quote of url value in CSS `url()` (#7718)
  Update @parcel/css and add diagnostic for url dependencies in custom properties (#7845)
  Use relative path for bundle labels in bundle analysis (#7737)
  Allow use react-jsx transform in React 16.14.0 (#7728)
  Move to @parcel/css by default (#7821)
  Feature: pick PORT number also from .env file (#7819)
  Enable parsing static initialization blocks (#7839)
  Bump swc and prevent pure comment removal (#7833)
  Bump swc (#7777)
  Human readable file size in bundle analyzer report (#7766)
  Improve emoji support detection (#7775)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emoji support check is biased
3 participants