Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NodeResolver check realpath before resolving with source entry #7846

Merged
merged 6 commits into from Mar 20, 2022

Conversation

g6123
Copy link
Contributor

@g6123 g6123 commented Mar 20, 2022

↪️ Pull Request

💻 Examples

For example, in the case of pnpm with default settings:

workspace/
  node_modules/
    .pnpm/compute-scroll-into-view@1.0.17/node_modules/compute-scroll-into-view/
      package.json
    compute-scroll-into-view/ -> symlink to .pnpm/compute-scroll-into-view@1.0.17/node_modules/compute-scroll-into-view
package.json

When trying to import compute-scroll-into-view from workspace, node_modules/compute-scroll-into-view/ is a symbolic link. So Parcel tries to read source field of compute-scroll-into-view, which points to an non-existing file.

🚨 Test instructions

I think the included test covers sufficient cases 🤔

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@devongovett devongovett merged commit 63f2a18 into parcel-bundler:v2 Mar 20, 2022
gorakong pushed a commit that referenced this pull request Nov 3, 2022
* upstream/v2:
  Upgrade Flow to 0.174.1 (#7849)
  v2.4.0
  v2.4.0 changelog
  Bump Parcel CSS
  Dynamic imports priority fix closes #6980 (#7061)
  fix(transformers): errors.map is not a function (#7672)
  Make NodeResolver check realpath before resolving with `source` entry (#7846)
  docs: fix wrong location documents (#7689)
  Fix: escape double quote of url value in CSS `url()` (#7718)
  Update @parcel/css and add diagnostic for url dependencies in custom properties (#7845)
  Use relative path for bundle labels in bundle analysis (#7737)
  Allow use react-jsx transform in React 16.14.0 (#7728)
  Move to @parcel/css by default (#7821)
  Feature: pick PORT number also from .env file (#7819)
  Enable parsing static initialization blocks (#7839)
  Bump swc and prevent pure comment removal (#7833)
  Bump swc (#7777)
  Human readable file size in bundle analyzer report (#7766)
  Improve emoji support detection (#7775)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants